Repository navigation
[GLUTEN-5741][CH] Fix core dump when executor exits - #5787
Merged
Merged
Conversation
|
Run Gluten Clickhouse CI |
exmy
commented
May 17, 2024
Contributor
Author
|
@baibaichen @zhztheplayer Could you help review this change? Thanks! |
|
Run Gluten Clickhouse CI |
Contributor
|
@exmy please update comment and merge it. |
Contributor
Author
done |
Contributor
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
liuneng1994
pushed a commit
that referenced
this pull request
Jun 6, 2024
… in executors are killed or interrupted (#5839) What changes were proposed in this pull request? Changes: Clean code: remove useless JNIs and classes under cpp-ch Support cancel for all gluten processors. It was triggered when task is killed or shut down. Make sure offheap memory free does not throw exception. Ref: https://zhuanlan.zhihu.com/p/65454580 (Fixes: #5787 #5823) How was this patch tested? Manual
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Fixes: #5741 #5744)
https://github.com/apache/incubator-gluten/blob/10182a52d409cb659169cbfe1d7f1869d9205dce/gluten-core/src/main/java/org/apache/gluten/vectorized/JniLibLoader.java#L131
When running on yarn cluster,
libPathis a symbolic link existed on the working directory of yarn container, like/data5/hadoop/yarn/local/usercache/xumingyong/appcache/application_1710462985812_777680/container_e57_1710462985812_777680_01_000321/./libch.so. It's anAPPLICATIONlevel resource and will be removed when container exits. So it may have been removed here when reading real path, which causesFiles.isSymbolicLink(Paths.get(libPath))return false in that the library (e.g. libch.so) cannot be unload and the methodJNI_OnUnloadcannot be invoked (which casuses core dump). As a workaround, we can read real path when loading the library.How was this patch tested?
manual tests