Repository navigation
[GLUTEN-2974] [VL] Minor refactor for AllocationListener and VeloxMemoryMamanger to non copyable and non assignable - #2916
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
e96c83e to
9414bb8
Compare
9dd3473 to
8a09348
Compare
8a09348 to
0b44412
Compare
|
@Yohahaha Would you like to do rebase? Thanks! |
0b44412 to
4cf9c1f
Compare
There was a problem hiding this comment.
Nit: this is not necessarily a local ref. Caller could pass a global ref in if wanted.
There was a problem hiding this comment.
We should limit usage, create listener from java call native, and pass local ref in, only convert to global ref in listener internal, let listener manage this ref, otherwise, we can not manage this ref easily.
I'm not sure whether newGlobalRef is idempotent...
|
Would you like to rebase ? Thanks! @Yohahaha |
4cf9c1f to
5353239
Compare
|
@zhztheplayer already rebased, but here has a network issue in CI, could you help re-run failed jobs? |
|
@rui-mo Would you like to take a look? |
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Fixes: #2974