Repository navigation
[VL] Support empty dataframe write - #2435
Merged
Merged
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
ulysses-you
changed the title
ulysses-you
force-pushed
the
empty-parquet-write
branch
from
July 22, 2023 05:17
a2d615c to
1840565
Compare
ulysses-you
force-pushed
the
empty-parquet-write
branch
from
July 25, 2023 02:41
1840565 to
d71162e
Compare
ulysses-you
changed the title
JkSelf
reviewed
Jul 25, 2023
|
|
||
| VELOX_REPO=https://github.com/oap-project/velox.git | ||
| VELOX_BRANCH=main | ||
| VELOX_REPO=https://github.com/NetEase/gluten-velox |
Contributor
There was a problem hiding this comment.
Please help to revert this change. Thanks.
JkSelf
approved these changes
Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If the write data is empty, we should write a valid parquet file rather than an empty file.
before:
after:
How was this patch tested?
Add test