Skip to content

[GLUTEN-12992][CORE] Drop the now-constant ">= 3.4" test gates - #13000

Closed
dedsec-terminal wants to merge 3 commits into
apache:mainfrom
dedsec-terminal:drop-spark34-test-gates
Closed

dedsec-terminal wants to merge 3 commits into
apache:mainfrom
dedsec-terminal:drop-spark34-test-gates

Conversation

@dedsec-terminal

Copy link
Copy Markdown

What changes are proposed in this pull request?

Following the removal of Spark 3.2 and Spark 3.3 support (#12902, #12981), Spark 3.4 is the lowest supported profile. Therefore, testWithMinSparkVersion(name, "3.4") is constant-true across all supported Spark profiles (3.4, 3.5, 4.0, 4.1).

This PR:

  1. Replaces all 57 occurrences of testWithMinSparkVersion(..., "3.4") across 14 test suite files with direct test(...) calls.
  2. Removes uncalled helper methods testWithRangeSparkVersion and ignoreWithSpecifiedSparkVersion in GlutenQueryTest.
  3. Keeps all live version gates on 3.5, 4.0, and 4.1 unchanged.

Fixes #12992.

How was this patch tested?

  • Verified all 57 call sites across the 14 suites were replaced with direct test(...) calls.
  • Verified live gates on 3.5, 4.0, and 4.1 remain intact.
  • Verified 0 remaining callers or declarations of testWithRangeSparkVersion and ignoreWithSpecifiedSparkVersion.
  • Verified git diff --check and confirmed line lengths comply with Scalafmt/Scalastyle 100-character limit.

Was this patch authored or co-authored using generative AI tooling?

Generated-by: Antigravity

Spark 3.4 is the lowest supported profile, so testWithMinSparkVersion(name, "3.4") is redundant. Drop all 57 call sites across 14 test files and remove unused helper methods testWithRangeSparkVersion and ignoreWithSpecifiedSparkVersion in GlutenQueryTest. Closes apache#12992.
Copilot AI lite review requested due to automatic review settings September 11, 2026 19:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

Signed-off-by: dedsec-terminal <dedsec.terminal@gmail.com>
Copilot AI review requested due to automatic review settings September 11, 2026 19:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

1 similar comment
@dedsec-terminal

Copy link
Copy Markdown
Author

Run Gluten Clickhouse CI on x86

Signed-off-by: dedsec-terminal <dedsec.terminal@gmail.com>
Copilot AI review requested due to automatic review settings September 13, 2026 13:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@dedsec-terminal

Copy link
Copy Markdown
Author

All four failed workflow groups stopped at the same Spotless violation in GlutenQueryTest.scala (one extra blank line), before their tests ran. Fixed in signed-off commit 1158d96. The fresh workflows are now awaiting maintainer approval.

@jackylee-ch

Copy link
Copy Markdown
Contributor

There is another PR, #13004, that addresses the same issue and also considers the Bolt backend. Could you take a look and see if we can consolidate the two?

@dedsec-terminal

Copy link
Copy Markdown
Author

Thanks for pointing this out. I compared the patches directly: #13004 includes all 57 constant Spark 3.4 guard replacements from this PR, keeps the two helper methods requested in review, and adds 38 Spark 3.2/3.3 replacements across nine Bolt files. Since no accepted change remains unique here, I’m closing #13000 in favor of the more complete #13004.

@jackylee-ch

Copy link
Copy Markdown
Contributor

Thanks for your work on this PR! I was hoping we could continue improving it, but I respect your decision to close it.

Really appreciate your contribution, and hope to see more contributions from you in the community!

@dedsec-terminal
dedsec-terminal deleted the drop-spark34-test-gates branch September 14, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CORE] Drop the now-constant ">= 3.4" test gates

3 participants