Repository navigation
[GLUTEN-12992][CORE] Drop the now-constant ">= 3.4" test gates - #13000
dedsec-terminal wants to merge 3 commits into
Conversation
Spark 3.4 is the lowest supported profile, so testWithMinSparkVersion(name, "3.4") is redundant. Drop all 57 call sites across 14 test files and remove unused helper methods testWithRangeSparkVersion and ignoreWithSpecifiedSparkVersion in GlutenQueryTest. Closes apache#12992.
|
Run Gluten Clickhouse CI on x86 |
Signed-off-by: dedsec-terminal <dedsec.terminal@gmail.com>
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
Signed-off-by: dedsec-terminal <dedsec.terminal@gmail.com>
|
Run Gluten Clickhouse CI on x86 |
|
All four failed workflow groups stopped at the same Spotless violation in GlutenQueryTest.scala (one extra blank line), before their tests ran. Fixed in signed-off commit 1158d96. The fresh workflows are now awaiting maintainer approval. |
|
There is another PR, #13004, that addresses the same issue and also considers the Bolt backend. Could you take a look and see if we can consolidate the two? |
|
Thanks for pointing this out. I compared the patches directly: #13004 includes all 57 constant Spark 3.4 guard replacements from this PR, keeps the two helper methods requested in review, and adds 38 Spark 3.2/3.3 replacements across nine Bolt files. Since no accepted change remains unique here, I’m closing #13000 in favor of the more complete #13004. |
|
Thanks for your work on this PR! I was hoping we could continue improving it, but I respect your decision to close it. Really appreciate your contribution, and hope to see more contributions from you in the community! |
What changes are proposed in this pull request?
Following the removal of Spark 3.2 and Spark 3.3 support (#12902, #12981), Spark 3.4 is the lowest supported profile. Therefore,
testWithMinSparkVersion(name, "3.4")is constant-true across all supported Spark profiles (3.4, 3.5, 4.0, 4.1).This PR:
testWithMinSparkVersion(..., "3.4")across 14 test suite files with directtest(...)calls.testWithRangeSparkVersionandignoreWithSpecifiedSparkVersioninGlutenQueryTest.Fixes #12992.
How was this patch tested?
test(...)calls.testWithRangeSparkVersionandignoreWithSpecifiedSparkVersion.git diff --checkand confirmed line lengths comply with Scalafmt/Scalastyle 100-character limit.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Antigravity