Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,11 @@ class VeloxOrcDataTypeValidationSuite extends VeloxWholeStageTransformerSuite {
" type2 where type1.struct.struct_1 = type2.struct.struct_1") { _ => }
}

test("Decimal type") {
// TODO: Re-enable once Velox implements HugeintValuesUsingHashTable::mergeWith.
// The hash join on decimal(38, 18) pushes a hugeint dynamic filter into the scan
// (velox#18159), and merging it with the existing IsNotNull filter throws
// "mergeWith() is not supported".
ignore("Decimal type") {
// Validation: BatchScan Project Aggregate Expand Sort Limit
runQueryAndCompare(
"select int, decimal from type1 " +
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,11 @@ class VeloxParquetDataTypeValidationSuite extends VeloxWholeStageTransformerSuit
" type2 where type1.struct.struct_1 = type2.struct.struct_1") { _ => }
}

test("Decimal type") {
// TODO: Re-enable once Velox implements HugeintValuesUsingHashTable::mergeWith.
// The hash join on decimal(38, 18) pushes a hugeint dynamic filter into the scan
// (velox#18159), and merging it with the existing IsNotNull filter throws
// "mergeWith() is not supported".
ignore("Decimal type") {
// Validation: BatchScan Project Aggregate Expand Sort Limit
runQueryAndCompare(
"select int, decimal from type1 " +
Expand Down
4 changes: 2 additions & 2 deletions ep/build-velox/src/get-velox.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ set -exu

CURRENT_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd)
VELOX_REPO=https://github.com/IBM/velox.git
VELOX_BRANCH=dft-2026_08_17
VELOX_ENHANCED_BRANCH=ibm-2026_08_17
VELOX_BRANCH=dft-2026_08_21
VELOX_ENHANCED_BRANCH=ibm-2026_08_21
VELOX_HOME=""
RUN_SETUP_SCRIPT=ON
ENABLE_ENHANCED_FEATURES=OFF
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -753,6 +753,12 @@ class VeloxTestSettings extends BackendTestSettings {
// rewrite `WindowExec -> WindowExecTransformer`
.exclude(
"SPARK-38237: require all cluster keys for child required distribution for window query")
// The window orderBy has no tie-breaker, so rows tied in the window order can be emitted
// in any order. Velox TopNRowNumber orders peer rows differently than Spark's stable sort,
// making the running-frame collect_list result differ on tied rows. Both results are valid.
.exclude(
"SPARK-45543: InferWindowGroupLimit causes bug if the other window functions" +
" haven't the same window frame as the rank-like functions")
enableSuite[GlutenDataFrameWindowFramesSuite]
// Local window fixes are not added.
.exclude("range between should accept int/long values as boundary")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1038,6 +1038,12 @@ class VeloxTestSettings extends BackendTestSettings {
// rewrite `WindowExec -> WindowExecTransformer`
.exclude(
"SPARK-38237: require all cluster keys for child required distribution for window query")
// The window orderBy has no tie-breaker, so rows tied in the window order can be emitted
// in any order. Velox TopNRowNumber orders peer rows differently than Spark's stable sort,
// making the running-frame collect_list result differ on tied rows. Both results are valid.
.exclude(
"SPARK-45543: InferWindowGroupLimit causes bug if the other window functions" +
" haven't the same window frame as the rank-like functions")
enableSuite[GlutenDataFrameWindowFramesSuite]
enableSuite[GlutenDataFrameWriterV2Suite]
enableSuite[GlutenDatasetAggregatorSuite]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1026,6 +1026,12 @@ class VeloxTestSettings extends BackendTestSettings {
// TODO: fix on Spark-4.1 introduced by https://github.com/apache/spark/pull/47856
.exclude(
"SPARK-49386: Window spill with more than the inMemoryThreshold and spillSizeThreshold")
// The window orderBy has no tie-breaker, so rows tied in the window order can be emitted
// in any order. Velox TopNRowNumber orders peer rows differently than Spark's stable sort,
// making the running-frame collect_list result differ on tied rows. Both results are valid.
.exclude(
"SPARK-45543: InferWindowGroupLimit causes bug if the other window functions" +
" haven't the same window frame as the rank-like functions")
enableSuite[GlutenDataFrameWindowFramesSuite]
enableSuite[GlutenDataFrameWriterV2Suite]
enableSuite[GlutenDatasetAggregatorSuite]
Expand Down
Loading