Repository navigation
[GLUTEN-11550][VL] Fix GlutenSetCommandSuite in Spark 4.x - #12533
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets re-enabling the Spark 4.x GlutenSetCommandSuite for the Velox backend by turning the suite back on in the Spark 4.0/4.1 test settings and adding the Hive test configuration resource that Spark’s SetCommandSuite expects on the test classpath.
Changes:
- Re-enabled
GlutenSetCommandSuiteinVeloxTestSettingsfor Spark 4.0 and Spark 4.1. - Added
hive-site.xmlunder Spark 4.0/4.1 test resources to support Hive-relatedSETcommand test expectations. - (Also) re-enabled
GlutenRandomDataGeneratorSuitefor Spark 4.1.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Re-enables Spark 4.1 suites (including GlutenSetCommandSuite; also re-enables GlutenRandomDataGeneratorSuite). |
| gluten-ut/spark41/src/test/resources/hive-site.xml | Adds Hive test configuration required by SetCommandSuite-style tests. |
| gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Re-enables GlutenSetCommandSuite for Spark 4.0. |
| gluten-ut/spark40/src/test/resources/hive-site.xml | Adds Hive test configuration required by SetCommandSuite-style tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .exclude("Query Spark logs with exception using SQL") | ||
| enableSuite[GlutenPercentileQuerySuite] | ||
| // TODO: 4.x enableSuite[GlutenRandomDataGeneratorSuite] // 232 failures | ||
| enableSuite[GlutenRandomDataGeneratorSuite] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added hive-site.xml to the Spark 4.x test resources because GlutenSetCommandSuite relies on the Hadoop configuration defined in Spark’s test environment.
The previously reported 232 failures in GlutenRandomDataGeneratorSuite on Spark 4.1 were local-environment issues: spark.test was not set, causing TimeType to be disabled.
Related issue: #11550