Skip to content

[GLUTEN-11088][VL] Fix ArithmeticAnsiValidateSuite #11150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhouyuan merged 1 commit into from
Nov 24, 2025
Merged

[GLUTEN-11088][VL] Fix ArithmeticAnsiValidateSuite #11150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions backends-velox/src/test/scala/org/apache/gluten/functions/ArithmeticAnsiValidateSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,21 @@ class ArithmeticAnsiValidateSuite extends FunctionsValidateSuite {
.set(SQLConf.ANSI_ENABLED.key, "true")
}

// TODO: fix on spark-4.0
testWithMaxSparkVersion("add", "3.5") {
test("add") {
runQueryAndCompare("SELECT int_field1 + 100 FROM datatab WHERE int_field1 IS NOT NULL") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
intercept[ArithmeticException] {
sql("SELECT 2147483647 + 1").collect()

val df = sql("SELECT 2147483647 + 1")

if (isSparkVersionGE("4.0")) {
intercept[SparkException] {
df.collect()
}
} else {
intercept[ArithmeticException] {
df.collect()
}
}
}

Expand All @@ -49,13 +57,20 @@ class ArithmeticAnsiValidateSuite extends FunctionsValidateSuite {
}
}

// TODO: fix on spark-4.0
testWithMaxSparkVersion("multiply", "3.5") {
test("multiply") {
runQueryAndCompare("SELECT int_field1 * 2 FROM datatab WHERE int_field1 IS NOT NULL") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
intercept[ArithmeticException] {
sql("SELECT 2147483647 * 2").collect()

val df = sql("SELECT 2147483647 + 1")
if (isSparkVersionGE("4.0")) {
intercept[SparkException] {
df.collect()
}
} else {
intercept[ArithmeticException] {
df.collect()
}
}
}

Expand Down