Skip to content

[VL] Add Unit-Test for VeloxSplitter - #1041

Merged
zuochunwei merged 2 commits into
apache:mainfrom
zuochunwei:unitTest
Feb 28, 2023
Merged

zuochunwei merged 2 commits into
apache:mainfrom
zuochunwei:unitTest

Conversation

@zuochunwei

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

  1. add tests for VeloxSplitter to validate the PR [VL shuffle] Add VeloxSplitter to split with velox::RowVector #1003
  2. this work is still in progress, you can review this PR when it's finished.

(Please fill in changes proposed in this fix)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[Gluten-${ISSUES_ID}] ${detailed message}

See also:

@zuochunwei
zuochunwei force-pushed the unitTest branch 3 times, most recently from c58a503 to 01e22c1 Compare February 28, 2023 06:03
zuochunwei added 2 commits February 28, 2023 04:27
# This is the 1st commit message:

add unit-test for VeloxSplitter

# This is the commit message #2:

update ut
@jinchengchenghh jinchengchenghh changed the title [VL] (WIP) add Unit-Test for VeloxSplitter [VL] Add Unit-Test for VeloxSplitter Feb 28, 2023
@zuochunwei
zuochunwei merged commit f49b0e2 into apache:main Feb 28, 2023
@zuochunwei
zuochunwei deleted the unitTest branch March 23, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants