Skip to content

[VL] Aggregate window gets the wrong result in 1.2.0 #7194

Closed
Closed
[VL] Aggregate window gets the wrong result in 1.2.0#7194
Assignees
JkSelf
Labels
bugSomething isn't workingtriage

Description

@ccat3z
ccat3z
opened on Sep 11, 2024

Backend

VL (Velox)

Bug description

Aggregate window gets the wrong result

-- Data
(for { x <- 1 to 4500 } yield { (x,1) }).toDF("id", "order_num")
     
-- Query
SELECT
  id,
  SUM(num) OVER(ORDER BY num DESC) AS sum
FROM test

Expect: sum: 4500

Actual: sum: 4096 ... 4500

Spark version

None

Spark configurations

No response

System information

No response

Relevant logs

No response

Activity

  1. ccat3z
    added
    bugSomething isn't working
    triage
    on Sep 11, 2024

  2. ccat3z commented on Sep 11, 2024

    @ccat3z
    ccat3z
    on Sep 11, 2024
    ContributorAuthor

    cc @kecookier

  3. ccat3z commented on Sep 11, 2024

    @ccat3z
    ccat3z
    on Sep 11, 2024
    ContributorAuthor

    This issue can be solved by disabling RowsStreamingWindowBuild. I guess that RowsStreamingWindowBuild might not be compatible with some aggregate case. I tried copying the logic of 'supportRowsStreaming()' from the update branch, but it didn't work. cc @JkSelf

  4. JkSelf commented on Sep 11, 2024

    @JkSelf
    JkSelf
    on Sep 11, 2024
    Contributor

    @ccat3z I will look at this issue later. Thanks.

  5. FelixYBW
    assigned
    JkSelf
    on Sep 11, 2024

  6. JkSelf commented on Sep 12, 2024

    @JkSelf
    JkSelf
    on Sep 12, 2024
    Contributor

    @ccat3z Can you help to verify facebookincubator/velox#10979 in your env? Thanks.

  7. ccat3z commented on Sep 12, 2024

    @ccat3z
    ccat3z
    on Sep 12, 2024
    ContributorAuthor

    @ccat3z Can you help to verify facebookincubator/velox#10979 in your env? Thanks.

    It works. Thanks.

  8. JkSelf commented on Sep 14, 2024

    @JkSelf
    JkSelf
    on Sep 14, 2024
    Contributor

    Fixed in facebookincubator/velox#10979.

  9. JkSelf
    closed this as completedon Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingtriage

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions