[FLINK-38587] Fix docker entrypoint script to preserve spaces in FLINK_PROPERTIES values#247
Open
wrmxs227 wants to merge 1 commit intoapache:masterfrom
Open
[FLINK-38587] Fix docker entrypoint script to preserve spaces in FLINK_PROPERTIES values#247wrmxs227 wants to merge 1 commit intoapache:masterfrom
wrmxs227 wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When FLINK_PROPERTIES contains values with spaces (e.g. JVM options like
--add-opens=java.base/java.util.concurrent.locks=ALL-UNNAMED --enable-preview),the entrypoint script strips all whitespace using
tr -d '[:space:]', causingthe options to be concatenated and become invalid.
Changes
Replace
tr -d '[:space:]'withsed 's/^[[:space:]]*//;s/[[:space:]]*$//'to only trim leading and trailing whitespace, preserving spaces within values.
Applied to all affected versions: 1.20, 2.0, 2.1, 2.2.
Testing
Verified with Docker Compose using a Flink 1.20.3 image with the fixed
entrypoint mounted. The WARNING about concatenated module options no longer
appears in the logs.
Related
https://issues.apache.org/jira/browse/FLINK-38587