Skip to content

fix: show a page for unknown routes - #590

Open
vansh-nagar wants to merge 2 commits into
apache:mainfrom
vansh-nagar:fix/show-not-found-page
Open

vansh-nagar wants to merge 2 commits into
apache:mainfrom
vansh-nagar:fix/show-not-found-page

Conversation

@vansh-nagar

Copy link
Copy Markdown

Unknown URLs now render a dedicated not-found page inside the authenticated application shell instead of silently rewriting the address to /dashboard.

The page keeps the requested URL visible, names the path that failed, moves focus to its heading for assistive technology, and links to the dashboard and global search using the app-owned UI primitives.

Checks run:

  • focused NotFoundComponent unit tests
  • ESLint on the changed TypeScript files
  • Prettier check on all changed files

Fixes #578

@vansh-nagar
vansh-nagar force-pushed the fix/show-not-found-page branch from 35d0483 to 35ac1a4 Compare September 22, 2026 09:32
@Aman-Mittal

Copy link
Copy Markdown
Member

@vansh-nagar Can you add a screenshot and e2e test

@Aman-Mittal

Copy link
Copy Markdown
Member

@vansh-nagar Please rebase and add e2e tests for this

@Aman-Mittal Aman-Mittal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NO e2e test

@github-actions

Copy link
Copy Markdown
Contributor

Commits on this pull request are not verified

1 of 2 commit is not showing as Verified on GitHub, so this pull request cannot be merged into main yet.

unsigned

These commits carry no signature at all.

  • a208376d test: cover unknown route recovery

How to fix: Set up commit signing, then re-sign the commits already on this branch. CONTRIBUTING.md has the setup.

Re-signing

# only for the identity reasons above (no_user / unverified_email):
git config user.email "you@example.com"

# re-sign every commit on this branch:
git rebase --exec 'git commit --amend --no-edit --reset-author -S' origin/main
git push --force-with-lease

Force-pushing is expected here — re-signing rewrites the commits, so their hashes change.


This comment is posted automatically and updates itself when you push; it disappears once every commit verifies. If you believe this is wrong, say so on the pull request — a maintainer can check.

@vnagar-oss

Copy link
Copy Markdown

Added the requested mocked Playwright coverage. The test opens an unknown URL, verifies the URL is preserved, checks the focused “Page not found” heading and requested-path message, then follows the dashboard recovery link. The focused browser test, E2E type-check, Prettier, and ESLint all pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unknown routes silently land on the Dashboard — there is no "page not found" screen

3 participants