Repository navigation
do not ignore ms in ruby time - #6217
Merged
Merged
Conversation
gianm
reviewed
Aug 23, 2018
| public void testRuby() | ||
| { | ||
| final Function<Object, DateTime> parser = TimestampParser.createObjectTimestampParser("ruby"); | ||
| Assert.assertEquals(DateTimes.of("2013-01-16T15:41:47+01:00"), parser.apply("1358347307.435447")); |
Contributor
There was a problem hiding this comment.
Will it still parse numbers out of strings?
Contributor
Author
There was a problem hiding this comment.
yeah, input in this test case is string.
Contributor
There was a problem hiding this comment.
Got it, sorry I missed that there was one in each.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
need it for some data we're indexing.
it might be backward incompatible for users who relied on parser truncating the ms away and not appropriately using indexing granularity to be second.
those users would need to change indexing granularity in the relevant task specs.