Repository navigation
Fix Kerberos Authentication failing requests without cookies and excludedPaths config. - #5596
Merged
Merged
Conversation
KerberosAuthenticator was failing `First` request from the clients. After authentication we were setting the cookie properly but not setting the the authenticated flag in the request. This PR fixed that. Additional Fixes - * Removing of Unused SpnegoFilterConfig - replaced by KerberosAuthenticator * Unused internalClientKeytab and principal from KerberosAuthenticator * Fix docs accordingly and add docs for configuring an escalated client.
Member
Author
nishantmonu51
changed the title
jon-wei
reviewed
Apr 9, 2018
|
|
||
| String path = ((HttpServletRequest) request).getRequestURI(); | ||
| if (isExcluded(path)) { | ||
| // For excluded paths that does NOT need to be authenticated. |
Contributor
There was a problem hiding this comment.
If there's an authorizer configured + the Kerberos authenticator, this won't be enough to skip security checks on a request (the authorizer would check what permissions the "anonymous" user would have and deny the request unless the user has configured appropriate permissions for the "anonymous" user)
To support excludedPaths, there's a similar concept with "unsecured paths" in the various service initialization files (e.g., UNSECURED_PATHS in CoordinatorJettyServerInitializer), one option could be to extend that to allow user-specified whitelist entries (i.e., make excludedPaths a general concept applied across all authenticators, and remove excludedPaths as a Kerberos-specific config).
I think excludedPaths makes more sense as a system-wide property than an authenticator-specific property, I'll suggest taking this out of this PR and one of us could do follow-on PR to make it a general config.
Member
Author
There was a problem hiding this comment.
@jon-wei: sure, we can make it a general config.
Will raise a separate PR for that.
Member
Author
Contributor
|
👍 after CI |
Contributor
|
👍 |
nishantmonu51
added a commit
to nishantmonu51/druid
that referenced
this pull request
Apr 10, 2018
…udedPaths config. (apache#5596) * Fix Kerberos Authentication failing requests without cookies. KerberosAuthenticator was failing `First` request from the clients. After authentication we were setting the cookie properly but not setting the the authenticated flag in the request. This PR fixed that. Additional Fixes - * Removing of Unused SpnegoFilterConfig - replaced by KerberosAuthenticator * Unused internalClientKeytab and principal from KerberosAuthenticator * Fix docs accordingly and add docs for configuring an escalated client. * Fix excluded path config behavior * spelling correction * Revert "spelling correction" This reverts commit fb754b4. * Revert "Fix excluded path config behavior" This reverts commit 3901047.
fjy
pushed a commit
that referenced
this pull request
Apr 10, 2018
…udedPaths config. (#5596) (#5621) * Fix Kerberos Authentication failing requests without cookies. KerberosAuthenticator was failing `First` request from the clients. After authentication we were setting the cookie properly but not setting the the authenticated flag in the request. This PR fixed that. Additional Fixes - * Removing of Unused SpnegoFilterConfig - replaced by KerberosAuthenticator * Unused internalClientKeytab and principal from KerberosAuthenticator * Fix docs accordingly and add docs for configuring an escalated client. * Fix excluded path config behavior * spelling correction * Revert "spelling correction" This reverts commit fb754b4. * Revert "Fix excluded path config behavior" This reverts commit 3901047.
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Apr 16, 2018
…udedPaths config. (apache#5596) (apache#5621) * Fix Kerberos Authentication failing requests without cookies. KerberosAuthenticator was failing `First` request from the clients. After authentication we were setting the cookie properly but not setting the the authenticated flag in the request. This PR fixed that. Additional Fixes - * Removing of Unused SpnegoFilterConfig - replaced by KerberosAuthenticator * Unused internalClientKeytab and principal from KerberosAuthenticator * Fix docs accordingly and add docs for configuring an escalated client. * Fix excluded path config behavior * spelling correction * Revert "spelling correction" This reverts commit fb754b4. * Revert "Fix excluded path config behavior" This reverts commit 3901047.
sathishsri88
pushed a commit
to sathishs/druid
that referenced
this pull request
May 8, 2018
…udedPaths config. (apache#5596) * Fix Kerberos Authentication failing requests without cookies. KerberosAuthenticator was failing `First` request from the clients. After authentication we were setting the cookie properly but not setting the the authenticated flag in the request. This PR fixed that. Additional Fixes - * Removing of Unused SpnegoFilterConfig - replaced by KerberosAuthenticator * Unused internalClientKeytab and principal from KerberosAuthenticator * Fix docs accordingly and add docs for configuring an escalated client. * Fix excluded path config behavior * spelling correction * Revert "spelling correction" This reverts commit fb754b4. * Revert "Fix excluded path config behavior" This reverts commit 3901047.
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
…udedPaths config. (apache#5596) * Fix Kerberos Authentication failing requests without cookies. KerberosAuthenticator was failing `First` request from the clients. After authentication we were setting the cookie properly but not setting the the authenticated flag in the request. This PR fixed that. Additional Fixes - * Removing of Unused SpnegoFilterConfig - replaced by KerberosAuthenticator * Unused internalClientKeytab and principal from KerberosAuthenticator * Fix docs accordingly and add docs for configuring an escalated client. * Fix excluded path config behavior * spelling correction * Revert "spelling correction" This reverts commit fb754b4. * Revert "Fix excluded path config behavior" This reverts commit 3901047.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KerberosAuthenticator was failing
Firstrequest from the clients.After authentication we were setting the cookie properly but not
setting the the authenticated flag in the request. This PR fixes that.
Additional Fixes -
KerberosAuthenticator
client.
Reproducing the Issue -