Repository navigation
Fix removeDataSource() and removeSegment() of SQLMetadataSegmentManager - #5001
Merged
Merged
Conversation
licl2014
reviewed
Apr 23, 2020
| final ConcurrentHashMap<String, DruidDataSource> emptyMap = new ConcurrentHashMap<>(); | ||
| ConcurrentHashMap<String, DruidDataSource> current; | ||
| do { | ||
| current = dataSourcesRef.get(); |
Contributor
There was a problem hiding this comment.
Here, there is no guarantee that dataSourcesRef is safe. it may be updated in for loop above. @jihoonson @gianm @jon-wei
Contributor
Contributor
Author
There was a problem hiding this comment.
Which for loop are you referring to? Can you link here? Also, there has been a pretty big refactoring for this class. Do you still see the same issue?
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removeDataSource() currently checks a snapshot of dataSources and returns false if the target dataSource doesn't exist in the snapshot. However, SQLMetadataSegmentManager updates the snapshot by polling periodically, and thus it's possible that the target dataSource isn't in the snapshot but in the metadata store. removeSegment() has a similar issue.
This patch fixes this issue. An unnecessary lock is also removed.
This change is