Repository navigation
Define earlyMessegeRejectPeriod as the period after the taskDuration - #4990
Merged
nishantmonu51 merged 1 commit intoOct 26, 2017
Merged
nishantmonu51 merged 1 commit into
nishantmonu51 merged 1 commit into
Conversation
gianm
approved these changes
Oct 20, 2017
gianm
left a comment
gianm
left a comment
Contributor
There was a problem hiding this comment.
LGTM. This style seems better. It's a behavior change, but the Kafka indexing service is experimental anyway, so I think it's ok to make changes like this without too much fanfare.
Will mark this "release notes" since the release notes should discuss the behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The earlyMessageRejectPeriod was defined as the period after the kafkaIndexTask created.
If user set the taskDuration as PT6H and earlyMesssageRejectPeriod as PT1H, this kafkaIndexTask will throw away the data of last 5 hours. I don't think it's a good way to define the message window.
I think message window should like：
message window = lateMessageRejectPeriod + taskDuration + earlyMesssageRejectPeriod
So I make a little change to define earlyMessegeRejectPeriod as the period after the taskDuration.
And add a little debug log.