Skip to content

groupBy v2: Better error message when resources are exhausted. - #4046

Merged
nishantmonu51 merged 2 commits into
apache:masterfrom
gianm:groupby-resource-error
Mar 14, 2017
Merged

nishantmonu51 merged 2 commits into
apache:masterfrom
gianm:groupby-resource-error

Conversation

@gianm

@gianm gianm commented Mar 13, 2017

Copy link
Copy Markdown
Contributor

Fixes #4043.

@gianm gianm added this to the 0.10.0 milestone Mar 13, 2017
@gianm

gianm commented Mar 14, 2017

Copy link
Copy Markdown
Contributor Author

Oops, need to fix some tests.

@himanshug

Copy link
Copy Markdown
Contributor

👍

1 similar comment
@nishantmonu51

Copy link
Copy Markdown
Member

👍

@nishantmonu51
nishantmonu51 merged commit e5c0dab into apache:master Mar 14, 2017
gianm added a commit to gianm/druid that referenced this pull request Mar 14, 2017
…e#4046)

* groupBy v2: Better error message when resources are exhausted.

Fixes apache#4043.

* Fix tests.
fjy pushed a commit that referenced this pull request Mar 14, 2017
#4054)

* groupBy v2: Better error message when resources are exhausted.

Fixes #4043.

* Fix tests.
@himanshug

Copy link
Copy Markdown
Contributor

@gianm sometimes queries fail and the error message still does not say exactly what was the cause, that makes tuning difficult.
what do you think about the throwing exception approach ( #3953 (comment) ) so that message is generated where error happens.

@gianm
gianm deleted the groupby-resource-error branch April 10, 2017 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants