Repository navigation
fix: ScanQueryFrameProcessor should not send offset to data servers. - #20588
Merged
Merged
Conversation
ScanQueryFrameProcessor currently includes the original offset and limit when sending queries to data servers. It should instead send an offset of zero and add the offset to the limit.
github-actions
Bot
added
Area - Batch Ingestion
Area - MSQ
FrankChen021
left a comment
FrankChen021
left a comment
Member
There was a problem hiding this comment.
🟢 Approval recommended
The data-server pushdown now removes the original offset and preserves enough rows for MSQ to apply the final offset and limit after combining sources. No merge-blocking issue was found.
Reviewed 2 of 2 changed files.
Validation: git diff --check passed. No tests or builds were run.
This is an automated review by Codex GPT-5.6-Luna(max)
capistrant
approved these changes
Oct 14, 2026
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScanQueryFrameProcessor currently includes the original offset and limit when sending queries to data servers. It should instead send an offset of zero and add the offset to the limit.