Repository navigation
test: wait for handoff notice completion in supervisor state test - #20453
Merged
Merged
Conversation
FrankChen021
left a comment
Member
There was a problem hiding this comment.
🟢 Approval recommended
No actionable issues found in the reviewed change. The new latch synchronizes the test with completion of the handoff notice handler, so the subsequent run observes the intended state transition instead of relying on queue size.
Reviewed 1 of 1 changed files.
Validation: GitHub reported the pull request as MERGEABLE with CLEAN merge state, local git merge-tree verification succeeded against origin/master, and git diff --check passed. No test commands were run during this review.
This is an automated review by Codex GPT-5.6 Luna(Max)
FrankChen021
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20429.
Description
testSupervisorStopTaskGroupEarlywaited for an empty notice queue before its secondrunInternal()call. The notice thread removes a handoff notice from the queue before handling it, so the test could run beforehandoffEarlywas set and miss the expected task shutdown.The test now waits on a latch released from
emitNoticeProcessTimeonly after thehandoff_task_group_noticehandler completes. The wait is bounded to five seconds under the existing ten-second test timeout. Production behavior is unchanged.Validation
master, JDK 25, Surefire retries disabled: the target test passed 1/1 locally. The intermittent failure was documented in the issue's CI jobs and did not reproduce in this single local run.-Dsurefire.rerunFailingTestsCount=0.SeekableStreamSupervisorStateTestclass passed: 61 tests, 0 failures, 0 errors, 0 skipped, with retries disabled.mvn -pl indexing-service checkstyle:check: 0 violations.git diff --check: passed.mvn validate -pl indexing-service -am -T1Cdid not reachindexing-service: PMD in the AWS and GCP common modules could not resolve the reactor'sdruid-processingsnapshot jar during thevalidatephase. The changed module's Checkstyle check was run directly as noted above.The test commands used
-pl indexing-service -am -Dsurefire.failIfNoSpecifiedTests=false -Dsurefire.rerunFailingTestsCount=0 -Pskip-static-checks -Dweb.console.skip=true -T1C, selecting the target method for the repeated runs and the full class for the class run.Key changed classes
SeekableStreamSupervisorStateTest: wait for the handoff notice to finish before asserting its effect.This PR has: