Skip to content

test(web-console): handle available capacity warning in MSQ e2e - #20443

Merged
FrankChen021 merged 1 commit into
apache:masterfrom
gitedmond:fix-msq-e2e-capacity-alert
Sep 30, 2026
Merged

FrankChen021 merged 1 commit into
apache:masterfrom
gitedmond:fix-msq-e2e-capacity-alert

Conversation

@gitedmond

Copy link
Copy Markdown
Contributor

Fixes #20438.

Description

The multi-stage query e2e test can encounter the workbench capacity warning when another spec’s compaction task occupies a slot. The helper previously waited for results while the dialog remained open, timing out after four minutes.

Wait for either the result pane or the specific warning about temporarily unavailable slots. If the warning appears, confirm “Run it anyway” and then wait for the result pane. The warning about insufficient total cluster capacity is intentionally left to fail, since that query cannot run.

Validation

  • npm run typecheck (after generating SQL docs): passed
  • ESLint and Prettier check for the changed file: passed
  • Full e2e run requires a Druid test cluster and has not been run locally.

This PR has:

  • been self-reviewed.

Added handling for capacity alert in query execution.

@FrankChen021 FrankChen021 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No actionable issues found. The helper recognizes the temporary available-slot warning, confirms the dialog to submit the query, and then waits for results; it leaves the insufficient-total-capacity warning unhandled as intended. The existing fresh browser context and browser teardown support the result-versus-dialog wait in this test.

Reviewed 1 of 1 changed files and inspected 7 supporting source/configuration files (8 files total), covering the calling e2e test, browser and table helpers, dialog implementation, query submission/rendering flow, and package configuration. Static review only; no tests or builds were run.


This is an automated review by Codex GPT-5.6-Luna(max)

@FrankChen021
FrankChen021 merged commit 0ad366d into apache:master Sep 30, 2026
22 checks passed
@github-actions github-actions Bot added this to the 39.0.0 milestone Sep 30, 2026
@gitedmond
gitedmond deleted the fix-msq-e2e-capacity-alert branch September 30, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: multi-stage-query.spec.ts "runs a query that reads external data" (web-console e2e)

2 participants