Repository navigation
test(web-console): handle available capacity warning in MSQ e2e - #20443
Merged
Merged
Conversation
Added handling for capacity alert in query execution.
FrankChen021
left a comment
Member
There was a problem hiding this comment.
🟢 Approval recommended
No actionable issues found. The helper recognizes the temporary available-slot warning, confirms the dialog to submit the query, and then waits for results; it leaves the insufficient-total-capacity warning unhandled as intended. The existing fresh browser context and browser teardown support the result-versus-dialog wait in this test.
Reviewed 1 of 1 changed files and inspected 7 supporting source/configuration files (8 files total), covering the calling e2e test, browser and table helpers, dialog implementation, query submission/rendering flow, and package configuration. Static review only; no tests or builds were run.
This is an automated review by Codex GPT-5.6-Luna(max)
FrankChen021
approved these changes
Sep 30, 2026
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20438.
Description
The multi-stage query e2e test can encounter the workbench capacity warning when another spec’s compaction task occupies a slot. The helper previously waited for results while the dialog remained open, timing out after four minutes.
Wait for either the result pane or the specific warning about temporarily unavailable slots. If the warning appears, confirm “Run it anyway” and then wait for the result pane. The warning about insufficient total cluster capacity is intentionally left to fail, since that query cannot run.
Validation
This PR has: