Repository navigation
fix: Fix flaky TaskQueueScaleTest.doMassLaunchAndExit - #20426
Closed
Akshat-Jain wants to merge 1 commit into
Closed
Akshat-Jain wants to merge 1 commit into
Akshat-Jain wants to merge 1 commit into
Conversation
Member
|
Thanks for the fix. However, a simple while-loop is not enough. It has been fixed by #20291 BTW, under the GitHub issue section, there's a series issues created by Claude Code everyday that triages CI failures in previous day, some of those are still open, hope someone can fix them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes flaky
TaskQueueScaleTest.doMassLaunchAndExit. Sample failure: https://github.com/apache/druid/actions/runs/36084362652/job/107912839489TaskQueueScaleTest.doMassLaunchAndExitreads the running, pending and waiting counts at three separate instants while theTaskQueue-Managerthread is still submitting tasks to the runner. SincegetWaitingTaskCount()counts active tasks the runner does not know about, a task that crossestaskRunner.run()between the pending read and the waiting read is counted by neither, so the sum comes up short (expected: <1000> but was: <988>).The test had a high failure rate without this PR change. With this PR change, I ran the test 100 times locally, it passes everytime.
This PR has: