Repository navigation
fix: partial segment bootstrap - #19630
Merged
clintropolis merged 2 commits intoJun 27, 2026
Merged
Conversation
FrankChen021
left a comment
FrankChen021
left a comment
Member
There was a problem hiding this comment.
I have reviewed the code for correctness, edge cases, concurrency, lifecycle, security/data loss/API compatibility, and missing-test risks; no issues found.
Reviewed 3 of 3 changed files.
This is an automated review by Codex GPT-5.5
capistrant
approved these changes
Jun 26, 2026
capistrant
left a comment
capistrant
left a comment
Contributor
There was a problem hiding this comment.
thanks for the catch and fix!
Contributor
|
from jacoco report - the exceptional case of a null range reader during bootstrap seems like important test coverage to make sure it behaves as desired to not blow up the server going forward. |
capistrant
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes partial segment bootstrapping to use the actual range reader when restoring entries instead of a stub that was initially added to ease testing (this should have been done as part of #19535 when stuff got wired up). Without this fix, bootstrapped entries that were not fully resident in the cache would fail to load on demand later since they were using a range reader that wasn't really functional.