Skip to content

test: Try to fix row-count race in flaky EmbeddedKafkaSupervisorTest #19581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abhishekrb19 merged 1 commit into from
Jun 15, 2026
Merged

test: Try to fix row-count race in flaky EmbeddedKafkaSupervisorTest #19581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ...e/src/test/java/org/apache/druid/indexing/kafka/simulate/EmbeddedKafkaSupervisorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,19 @@ public void test_runKafkaSupervisor()
Assertions.assertEquals(1, taskStatuses.size());
Assertions.assertEquals(TaskState.RUNNING, taskStatuses.get(0).getStatusCode());

// Wait until all produced records have been ingested before verifying the row count,
// otherwise the query below can race ingestion and observe fewer than the expected rows
indexer.latchableEmitter().waitForEventAggregate(
event -> event.hasMetricName("ingest/events/processed")
.hasDimension(DruidMetrics.DATASOURCE, dataSource),
agg -> agg.hasSumAtLeast(expectedSegments)
);

// Verify the count of rows ingested into the datasource so far
Assertions.assertEquals("10", cluster.runSql("SELECT COUNT(*) FROM %s", dataSource));
Assertions.assertEquals(
String.valueOf(expectedSegments),
cluster.runSql("SELECT COUNT(*) FROM %s", dataSource)
);

// Suspend the supervisor and verify the state
cluster.callApi().postSupervisor(kafkaSupervisorSpec.createSuspendedSpec());
Expand Down
Loading