Repository navigation
Move error and retry query integration tests into embedded suite - #18786
Merged
Merged
Conversation
Fly-Style
force-pushed
the
it-to-embed-query
branch
from
November 28, 2025 11:17
c0781e4 to
92ec744
Compare
Fly-Style
force-pushed
the
it-to-embed-query
branch
from
November 28, 2025 12:35
92ec744 to
1ffeec3
Compare
Fly-Style
marked this pull request as ready for review
November 28, 2025 13:12
Fly-Style
force-pushed
the
it-to-embed-query
branch
from
November 28, 2025 15:11
43668fe to
2e4bec3
Compare
kfaraz
reviewed
Nov 29, 2025
kfaraz
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR, @Fly-Style !
I have left some thoughts.
Contributor
|
@Fly-Style , since we are getting rid of
|
Fly-Style
marked this pull request as draft
November 30, 2025 15:50
Fly-Style
force-pushed
the
it-to-embed-query
branch
from
December 1, 2025 12:39
3038d0b to
206dbbf
Compare
Fly-Style
force-pushed
the
it-to-embed-query
branch
from
December 1, 2025 16:36
206dbbf to
0d5cde4
Compare
Fly-Style
marked this pull request as ready for review
December 1, 2025 16:38
Fly-Style
force-pushed
the
it-to-embed-query
branch
from
December 2, 2025 09:12
5bae0ba to
c6612ce
Compare
kfaraz
approved these changes
Dec 2, 2025
kfaraz
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
+1 after CI passes.
kfaraz
reviewed
Dec 2, 2025
kfaraz
reviewed
Dec 3, 2025
Fly-Style
force-pushed
the
it-to-embed-query
branch
from
December 3, 2025 08:02
21cf551 to
1727a1b
Compare
Fly-Style
force-pushed
the
it-to-embed-query
branch
from
December 3, 2025 08:03
1727a1b to
b3d163f
Compare
…dedClusterApis.java Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com>
Fly-Style
force-pushed
the
it-to-embed-query
branch
from
December 3, 2025 13:03
5d960ff to
a303bda
Compare
kfaraz
reviewed
Dec 3, 2025
| # limitations under the License. | ||
|
|
||
| org.apache.druid.testing.tools.CustomNodeRoleClientModule | ||
| org.apache.druid.testing.tools.CustomNodeRoleClientModule No newline at end of file |
Contributor
There was a problem hiding this comment.
I think this change can be reverted (only if you are pushing any other changes too)
Contributor
|
Nice to finally see a successful run! 🎉 🎉 |
Contributor
|
@Fly-Style , I am going ahead with the merge of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patch continues the effort to move query group tests to the embedded test suite, currently, we have migrated
ITQueryErrorTestandITQueryRetryTestOnMissingSegmentsAs part of this effort, we also created a base class for the convenience of the next usages.
Note #1: the queries used in tests are not equal to the previous version, mostly because they sense just don't matter, the key thing is the errors it is throwing.
Note #2: TLS-related tests require more effort to support, so we decided to implement them in subsequent patches.
Key changed/added classes in this PR
ITQueryErrorTestQueryErrorTestITQueryRetryTestOnMissingSegmentsQueryRetryOnMissingSegmentTestQueryTestBaseThis PR has: