Repository navigation
Refactor: Remove type params from MetadataStorageActionHandler - #18479
Merged
Merged
Conversation
…ta_storage_handler
…ta_storage_handler
jtuglu1
approved these changes
Sep 4, 2025
| DateTime createdTime | ||
| ) | ||
| { | ||
| this.taskId = taskId; |
Contributor
There was a problem hiding this comment.
I'm assuming we don't want to perform validations on these fields?
Contributor
Author
There was a problem hiding this comment.
Do you mean a null check?
kfaraz
changed the title
gianm
approved these changes
Sep 5, 2025
Contributor
Author
riovic918data
added a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
…e#18479) Description: The `MetadataStorageActionHandler` deals with persistence of `Task` and related objects. But those model classes exist in `indexing-service` module which forces the `MetadataStorageActionHandler` to handle generics unnecessarily. This makes the code cluttered and difficult to understand at times. Changes: - Move `MetadataStorageActionHandler` and factory classes to `indexing-service` module - Move implementations to respective extensions - Simplify class `TaskInfo` by removing type parameters - Add class `TaskIdStatus` - Remove class `TaskStuff` - Add `DerbyTaskStorageModule` to bind the `MetadataStorageActionHandler` to its default impl on `CliOverlord` - Remove references to the tasklog table as it had been disabled in apache#16309
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
MetadataStorageActionHandlerdeals with persistence ofTaskand related objects.But those model classes exist in
indexing-servicemodule which forces theMetadataStorageActionHandlerto handle generics unnecessarily. This makes the code cluttered and difficult to understand at times.
Changes
MetadataStorageActionHandlerand factory classes toindexing-servicemoduleTaskInfoby removing type parametersTaskIdStatusTaskStuffDerbyTaskStorageModuleto bind theMetadataStorageActionHandlerto its default impl onCliOverlordDeveloper notes
The
MetadataStorageActionHandlerextension point is being updated to have simpler APIs.This is a breaking change for any SQL metadata extensions in the wild.
The changes for PostgreSQL, MySQL and SQLServer are already handled in this PR.
This PR has: