Repository navigation
Use GraalJS to execute javascript backed selector strategies - #17843
Merged
Merged
Conversation
kgyrtkirk
changed the title
cryptoe
approved these changes
Apr 1, 2025
Contributor
|
@kgyrtkirk The CI failures look legit though . |
3 of 10 tasks
maytasm
reviewed
Apr 2, 2025
maytasm
left a comment
maytasm
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for getting this over the line and merged.
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
…17843) This is an alternate approach to fix the selectors similarily to: apache#14795 This PR adds GraalJS - and configures the system to use that instead of the previously jdk built-in nashorn engine. Incorporating Nashorn into the project would be more complicated as it would (beyond other thing) would require the end user to manually install it (its also not that much maintained)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternate approach to fix the selectors similarily to: #14795
This PR adds
GraalJS- and configures the system to use that instead of the previously jdk built-in nashorn engine.Incorporating Nashorn into the project would be more complicated as it would (beyond other thing) would require the end user to manually install it (its also not that much maintained)
Release note
Added GraalJS to enable back javascript backed selector strategies support out of the box.
This PR has: