Repository navigation
Improve concurrency in TaskQueue #17828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ab8b89a
Improve concurrency in TaskQueue
kfaraz 866f14e
Handle race conditions with sync
kfaraz 18b62fa
Rename giant to startStopLock
kfaraz 4899e2b
Merge branch 'master' of github.com:apache/druid into remove_taskqueu…
kfaraz 536beaa
Add CollectionUtils.toMap
kfaraz 8b3c332
Merge branch 'master' of github.com:apache/druid into remove_taskqueu…
kfaraz 154b08c
Add TaskQueueConcurrencyTest
kfaraz c58ea8e
Fix checkstyle
kfaraz 1391166
Simplify tests
kfaraz 9aed4e8
Minor cleanup
kfaraz d8158d1
Add more tests with start/stop
kfaraz 6c4dcf4
Fix checkstyle
kfaraz c671d82
Merge branch 'master' of github.com:apache/druid into remove_taskqueu…
kfaraz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
141 changes: 79 additions & 62 deletions
141
...service/src/test/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java
Large diffs are not rendered by default.
Oops, something went wrong.
150 changes: 85 additions & 65 deletions
150
...ice/src/test/java/org/apache/druid/indexing/kinesis/supervisor/KinesisSupervisorTest.java
Large diffs are not rendered by default.
Oops, something went wrong.
554 changes: 298 additions & 256 deletions
554
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably remove line 4296 and 4298 and fold them inside the else at 4301. The resulting method would be much leaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplified.