Skip to content

Pull Dependencies only once - #17321

Open
shigarg1 wants to merge 5 commits into
apache:masterfrom
shigarg1:deps
Open

shigarg1 wants to merge 5 commits into
apache:masterfrom
shigarg1:deps

Conversation

@shigarg1

Copy link
Copy Markdown
Contributor

Fixes #17014

As part of this, there will still be some copies but it significantly reduces the overall size.

Currently there can be three copies

  1. in lib
  2. from dist profile
  3. from bundle-contrib-exts profile

Distribution size before fix - 911M
Distribution size after fix - 603M

@abhishekagarwal87

Copy link
Copy Markdown
Contributor

Extensions don't access jars that are in the other extension folders. Have you considered that?

@shigarg1

Copy link
Copy Markdown
Contributor Author

Extensions don't access jars that are in the other extension folders. Have you considered that?

No, I did not know about this. Will they have access to jars in lib folder?

@abhishekagarwal87

Copy link
Copy Markdown
Contributor

Extensions don't access jars that are in the other extension folders. Have you considered that?

No, I did not know about this. Will they have access to jars in lib folder?

Yes

@shigarg1

Copy link
Copy Markdown
Contributor Author

@cryptoe can you please help to review this.

@FrankChen021 FrankChen021 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MergeLens review deferred: this PR currently has a definite merge conflict with master.

Current head: deps at 5c52ec066f9ffba07d614957822f0c7445a1cfa6.
Please resolve the conflicts with master and push a new head so the code can be reviewed. Reviewed 0 files; review was deferred because the PR conflicts with master.


This is an automated review by Codex GPT-5.6-Luna(max)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce the size of the druid tar.

3 participants