Skip to content

remove aws-sdk from ranger-extension - #16011

Merged
xvrl merged 8 commits into
apache:masterfrom
janjwerner-confluent:remove-azure-sdk-from-ranger
Mar 8, 2024
Merged

xvrl merged 8 commits into
apache:masterfrom
janjwerner-confluent:remove-azure-sdk-from-ranger

Conversation

@janjwerner-confluent

Copy link
Copy Markdown
Contributor

Fixes # size blowup regression introduced in #15443

Description

This PR removes the transitive dependency of ranger-plugins-audit to reduce the size of the compiled artifacts

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@LakshSingla

Copy link
Copy Markdown
Contributor

Is it safe to exclude the dependency? Last I checked, the ranger did rely on AWS Cloudwatch for some things. Do we not use that functionality in Druid?

Comment thread extensions-core/druid-ranger-security/pom.xml
Comment thread extensions-core/druid-ranger-security/pom.xml Outdated

@xvrl xvrl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once static checks / tests pass.

Comment thread extensions-core/druid-ranger-security/pom.xml Outdated
@abhishekagarwal87

Copy link
Copy Markdown
Contributor

why does the description says "azure-sdk"?

@janjwerner-confluent janjwerner-confluent changed the title remove azure-sdk from ranger-extension remove aws-sdk from ranger-extension Mar 5, 2024
@janjwerner-confluent

Copy link
Copy Markdown
Contributor Author

why does the description says "azure-sdk"?

brain freeze I guess, fixed it :)

@xvrl
xvrl merged commit a7b2747 into apache:master Mar 8, 2024
@janjwerner-confluent
janjwerner-confluent deleted the remove-azure-sdk-from-ranger branch March 8, 2024 15:46
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
riovic918data pushed a commit to riovic918data/druid that referenced this pull request Jun 12, 2026
Fixes # size blowup regression introduced in apache#15443

This PR removes the transitive dependency of ranger-plugins-audit to reduce the size of the compiled artifacts

* add aws-logs-sdk to ensure that all the transitive dependencies are satisfied
* replace aws-bundle-sdk with aws-logs-sdk
* add additional guidance on ranger update, add dependency ignore to satisfy dependency analyzer
* add aws-sdk-logs to list of ignored dependencies to satisfy the maven plugin
* align aws-sdk versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants