Skip to content

Use cache for password hash while validating LDAP password - #15993

Merged
kfaraz merged 3 commits into
apache:masterfrom
kfaraz:cache_ldap_hash
Feb 28, 2024
Merged

Use cache for password hash while validating LDAP password#15993
kfaraz merged 3 commits into
apache:masterfrom
kfaraz:cache_ldap_hash

Conversation

@kfaraz

@kfaraz kfaraz commented Feb 28, 2024

Copy link
Copy Markdown
Contributor

Follow up to #15648

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kfaraz
kfaraz merged commit f757231 into apache:master Feb 28, 2024
@kfaraz
kfaraz deleted the cache_ldap_hash branch February 28, 2024 13:03
@kfaraz

kfaraz commented Feb 28, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the review, @abhishekagarwal87 !

@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
@adarshsanjeev adarshsanjeev mentioned this pull request May 28, 2024
Closed
riovic918data added a commit to riovic918data/druid that referenced this pull request Jun 12, 2026
@riovic918data
Use cache for password hash while validating LDAP password (apache#15993
e75d400 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhishekagarwal87 abhishekagarwal87 abhishekagarwal87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

30.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kfaraz @abhishekagarwal87 @adarshsanjeev