Repository navigation
Clean up after add kill bufferPeriod - #14868
Merged
Merged
Conversation
kfaraz
changed the title
Contributor
Author
|
Thanks for the review, @jon-wei ! |
riovic918data
added a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
Follow up changes to apache#12599 Changes: - Rename column `used_flag_last_updated` to `used_status_last_updated` - Remove new CLI tool `UpdateTables`. - We already have a `CreateTables` with similar functionality, which should be able to handle update cases too. - Any user running the cluster for the first time should either just have `connector.createTables` enabled or run `CreateTables` which should create tables at the latest version. - For instance, the `UpdateTables` tool would be inadequate when a new metadata table has been added to Druid, and users would have to run `CreateTables` anyway. - Remove `upgrade-prep.md` and include that info in `metadata-init.md`. - Fix log messages to adhere to Druid style - Use lambdas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up PR to #12599
That PR introduces some changes that can be simplified.
Changes
used_flag_last_updatedtoused_status_last_updatedUpdateTables.CreateTableswith similar functionality, which should be able to handle update cases too.druid.metadata.storage.connector.createTablesenabled or runCreateTableswhich should create tables at the latest version.UpdateTablestool would be inadequate when a new metadata table has been added to Druid, and users would have to runCreateTablesanyway.upgrade-prep.mdand include that info inmetadata-init.md.This PR has: