Skip to content

Remove config druid.coordinator.compaction.skipLockedIntervals - #14807

Merged
kfaraz merged 2 commits into
apache:masterfrom
kfaraz:remove_config_skip_locked
Aug 14, 2023
Merged

kfaraz merged 2 commits into
apache:masterfrom
kfaraz:remove_config_skip_locked

Conversation

@kfaraz

@kfaraz kfaraz commented Aug 14, 2023 •

Copy link
Copy Markdown
Contributor

Description

The default of the config druid.coordinator.compaction.skipLockedIntervals has been true for many releases and has been working as expected. There is no case in which we would want this to be false anyway.

Release note

The config druid.coordinator.compaction.skipLockedIntervals is being removed as it has been tested thoroughly and should always be true.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kfaraz
kfaraz merged commit 786e772 into apache:master Aug 14, 2023
@kfaraz
kfaraz deleted the remove_config_skip_locked branch August 14, 2023 07:01
@kfaraz

kfaraz commented Aug 14, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the review, @AmatyaAvadhanula !

@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
riovic918data added a commit to riovic918data/druid that referenced this pull request Jun 12, 2026
…che#14807)

The value of `druid.coordinator.compaction.skipLockedIntervals` should always be `true`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants