Skip to content

Web console: make retention dialog clearer - #14793

Merged
vogievetsky merged 5 commits into
apache:masterfrom
vogievetsky:make_rules_ux_better
Aug 11, 2023
Merged

Web console: make retention dialog clearer#14793
vogievetsky merged 5 commits into
apache:masterfrom
vogievetsky:make_rules_ux_better

Conversation

@vogievetsky

@vogievetsky vogievetsky commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

Small UX tweaks to the retention dialog around how the cluster default rules are presented

Form mode:

image

JSON mode:

image
  1. Render the default rules in the same way as the datasource rules just disabled
  2. when switching the the JSON view the defaults turn to read only JSON also to show, intuitively, that they are the "same type of thing"
  3. Added some explanatory text after the "Cluster defaults" label.

suneet-s
suneet-s reviewed Aug 10, 2023
View reviewed changes
Comment thread web-console/src/dialogs/retention-dialog/retention-dialog.tsx Outdated
@vogievetsky @suneet-s
Update web-console/src/dialogs/retention-dialog/retention-dialog.tsx
62aa44b 
Co-authored-by: Suneet Saldanha <suneet@apache.org>
suneet-s
suneet-s approved these changes Aug 11, 2023
View reviewed changes

@suneet-s suneet-s left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 after CI. Thanks @vogievetsky !

@vogievetsky
vogievetsky merged commit b0c78ff into apache:master Aug 11, 2023
@vogievetsky
vogievetsky deleted the make_rules_ux_better branch August 11, 2023 16:43
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
@LakshSingla LakshSingla mentioned this pull request Nov 4, 2023
Closed
riovic918data pushed a commit to riovic918data/druid that referenced this pull request Jun 12, 2026
@vogievetsky @suneet-s
Web console: make retention dialog clearer (apache#14793)
781d3cb 
* make retention dialog clearer

* tweak

* another tweak

* Update web-console/src/dialogs/retention-dialog/retention-dialog.tsx

Co-authored-by: Suneet Saldanha <suneet@apache.org>

* update snapshot for copy

---------

Co-authored-by: Suneet Saldanha <suneet@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suneet-s suneet-s suneet-s approved these changes

Assignees

No one assigned

Labels

Area - Web Console

Projects

None yet

Milestone

28.0

Development

Successfully merging this pull request may close these issues.

3 participants

@vogievetsky @suneet-s @LakshSingla