Repository navigation
Web console: adding format notice for CSV and TSV - #14783
Merged
Merged
Conversation
317brian
requested changes
Aug 8, 2023
ektravel
reviewed
Aug 8, 2023
| if (firstLine === '{') { | ||
| return ( | ||
| <> | ||
| This data looks like multi-line formatted JSON object. For Druid to parse a text file it |
Contributor
There was a problem hiding this comment.
Suggested change
| This data looks like multi-line formatted JSON object. For Druid to parse a text file it | |
| This data looks like a multi-line formatted JSON object. For Druid to parse a text file it |
ektravel
reviewed
Aug 8, 2023
| const formatLabel = format.type.toUpperCase(); | ||
| return ( | ||
| <> | ||
| {`This ${formatLabel} data has values that contain new lines. Druid requires ${formatLabel} files to have one event per line and thus ${formatLabel} values can not contain new lines. Consider encoding new lines in the values of your ${formatLabel} with some special delimiter.`} |
Contributor
There was a problem hiding this comment.
Suggested change
| {`This ${formatLabel} data has values that contain new lines. Druid requires ${formatLabel} files to have one event per line and thus ${formatLabel} values can not contain new lines. Consider encoding new lines in the values of your ${formatLabel} with some special delimiter.`} | |
| {`This ${formatLabel} data has values that contain new lines. Druid requires ${formatLabel} files to have one event per line, so ${formatLabel} values cannot contain new lines. Consider encoding new lines in the values of your ${formatLabel} with some special delimiter.`} |
Co-authored-by: 317brian <53799971+317brian@users.noreply.github.com>
Co-authored-by: 317brian <53799971+317brian@users.noreply.github.com>
Co-authored-by: 317brian <53799971+317brian@users.noreply.github.com>
clintropolis
approved these changes
Aug 15, 2023
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
* adding format notice for CSV and TSV * Update web-console/src/druid-models/ingestion-spec/ingestion-spec.tsx Co-authored-by: 317brian <53799971+317brian@users.noreply.github.com> * Update web-console/src/druid-models/ingestion-spec/ingestion-spec.tsx Co-authored-by: 317brian <53799971+317brian@users.noreply.github.com> * Update web-console/src/druid-models/ingestion-spec/ingestion-spec.tsx Co-authored-by: 317brian <53799971+317brian@users.noreply.github.com> * fix tests --------- Co-authored-by: 317brian <53799971+317brian@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a warning that the CSV or TSV sample contains newlines in values which is allowed in the format but Druid will not accept it in the expected way. Adding this because I got really tripped up by this myself.
Try it with:
Feedback on copy very welcome.
Also changed the links from http://ndjson.org/ to https://jsonlines.org (due to ndjson/ndjson-spec#35 (comment))