Repository navigation
Improve exception message when DruidLeaderClient doesn't find leader node - #14775
Merged
abhishekagarwal87 merged 4 commits intoAug 10, 2023
Merged
Conversation
| if (leader == null) { | ||
| throw new IOE("No known server"); | ||
| throw DruidException.forPersona(DruidException.Persona.ADMIN) | ||
| .ofCategory(DruidException.Category.NOT_FOUND) |
Contributor
There was a problem hiding this comment.
it should be RUNTIME_FAILURE and not NOT_FOUND.
Contributor
Author
There was a problem hiding this comment.
I wasn't sure between the two. I also think RUNTIME_FAILURE is apt since the leader server wasn't set and hence couldn't be found due to some failure.
| throw DruidException.forPersona(DruidException.Persona.ADMIN) | ||
| .ofCategory(DruidException.Category.NOT_FOUND) | ||
| .build( | ||
| "No leader server found for NodeRole [%s] and leaderRequestPath [%s].", |
Contributor
There was a problem hiding this comment.
NodeRole is a technical internal term. Instead, you can do something like below
"A leader node could not be found for [%s] service. check the logs of [%s] service to validate that service is healthy. ", nodeRole, nodeRole
| ); | ||
| } | ||
|
|
||
| private String getCurrentKnownLeader(final boolean cached) throws IOException |
Contributor
There was a problem hiding this comment.
I am a bit hesitant of changing the type of exception here. Since callers might be catching this right now. Maybe keep it IOException for now and just change the error message.
Contributor
Author
There was a problem hiding this comment.
Yes, that makes sense. Let me just update the exception message.
findingrish
changed the title
Contributor
|
there are test failures that need to be addressed. |
Comment on lines
+268
to
+269
| "A leader node could not be found for [%s] service. Check logs to validate service health.", | ||
| nodeRoleToWatch |
Contributor
There was a problem hiding this comment.
Suggested change
| "A leader node could not be found for [%s] service. Check logs to validate service health.", | |
| nodeRoleToWatch | |
| "A leader node could not be found for [%s] service. Check logs of service [%s] to confirm it is healthy.", | |
| nodeRoleToWatch, nodeRoleToWatch |
10 tasks
abhishekagarwal87
approved these changes
Aug 10, 2023
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
…node (apache#14775) The existing exception message No known server thrown in DruidLeaderClient is unhelpful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing exception message
No known serverthrown inDruidLeaderClientis unhelpful.This pr updates the message to be informative and actionable.