Repository navigation
MSQ WorkerImpl: Ignore ServiceClosedException on postCounters. - #14707
Merged
Merged
Conversation
A race can happen where postCounters is in flight while the controller goes offline. When this happens, we should ignore the ServiceClosedException and continue without posting counters.
gianm
added
the
Area - MSQ
georgew5656
reviewed
Jul 31, 2023
| log.debug(e, "Ignoring failure on postCounters, because controller has gone away."); | ||
| } | ||
|
|
||
| throw e; |
Contributor
There was a problem hiding this comment.
won't this just rethrow the ServiceClosedException with a extra log?
Contributor
Author
There was a problem hiding this comment.
Oops. Yes. Fixed. Thanks.
georgew5656
approved these changes
Jul 31, 2023
LakshSingla
approved these changes
Jul 31, 2023
Contributor
Author
|
CI is failing due to code coverage. This particular section of code isn't super easy to write a test for. I could do it, but before tackling that I wanted to ask if people would be OK with merging this without coverage? |
Contributor
works for me |
cryptoe
approved these changes
Aug 2, 2023
Contributor
|
Thanks for the PR @gianm!! |
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
…e#14707) * MSQ WorkerImpl: Ignore ServiceClosedException on postCounters. A race can happen where postCounters is in flight while the controller goes offline. When this happens, we should ignore the ServiceClosedException and continue without posting counters. * Fix style and logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A race can happen where postCounters is in flight while the controller goes offline. When this happens, we should ignore the ServiceClosedException and continue without posting counters.