Repository navigation
Improve alert message for segment assignments - #14696
Merged
Merged
Conversation
…segment_assignment
AmatyaAvadhanula
approved these changes
Aug 1, 2023
Contributor
Author
|
Thanks for the review, @AmatyaAvadhanula ! |
riovic918data
added a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
Changes: - Add interface `SegmentDeleteHandler` for marking segments as unused - In `StrategicSegmentAssigner`, collect all segments on which a drop rule applies in a list - Process the list above as a batch delete rather than individual deletes - Improve alert messages when an invalid tier is specified in a load rule - Improve alert message when no rule applies on a segment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
SegmentDeleteHandlerfor marking segments as unusedStrategicSegmentAssigner, collect all segments on which a drop rule applies in a listThis PR has: