Skip to content

Improve alert message for segment assignments - #14696

Merged
kfaraz merged 2 commits into
apache:masterfrom
kfaraz:fix_alerts_for_segment_assignment
Aug 1, 2023
Merged

kfaraz merged 2 commits into
apache:masterfrom
kfaraz:fix_alerts_for_segment_assignment

Conversation

@kfaraz

@kfaraz kfaraz commented Jul 30, 2023 •

Copy link
Copy Markdown
Contributor

Changes:

  • Add interface SegmentDeleteHandler for marking segments as unused
  • In StrategicSegmentAssigner, collect all segments on which a drop rule applies in a list
  • Process the list above as a batch delete rather than individual deletes
  • Improve alert messages when an invalid tier is specified in a load rule
  • Improve alert message when no rule applies on a segment

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kfaraz
kfaraz merged commit ee4e0c9 into apache:master Aug 1, 2023
@kfaraz
kfaraz deleted the fix_alerts_for_segment_assignment branch August 1, 2023 18:03
@kfaraz

kfaraz commented Aug 1, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the review, @AmatyaAvadhanula !

@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
riovic918data added a commit to riovic918data/druid that referenced this pull request Jun 12, 2026
Changes:
- Add interface `SegmentDeleteHandler` for marking segments as unused
- In `StrategicSegmentAssigner`, collect all segments on which a drop rule applies in a list
- Process the list above as a batch delete rather than individual deletes
- Improve alert messages when an invalid tier is specified in a load rule
- Improve alert message when no rule applies on a segment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants