Skip to content

Improve streaming ingestion completion timeout error message - #14636

Merged
AmatyaAvadhanula merged 4 commits into
apache:masterfrom
AmatyaAvadhanula:improve-completionTimeout-message
Aug 22, 2023
Merged

AmatyaAvadhanula merged 4 commits into
apache:masterfrom
AmatyaAvadhanula:improve-completionTimeout-message

Conversation

@AmatyaAvadhanula

Copy link
Copy Markdown
Contributor

A streaming ingestion supervisor spec has the property: completionTimeout (defaults to 30 minutes), which is the total time to wait after the taskDuration has elapsed for the tasks to stop reading, create segments from intermediate persists, publish segments to deep storage, and finally hand them off from the peons to the historicals.

A task fails if the above operations are not completed before the completionTimeout has elapsed.

This PR adds steps for better debugging when such failures occur.

Comment on lines +3275 to +3276
+ "Please check the total time taken for each segment's creation and publish to deep storage, "
+ "as well as the total time taken for segment handoff to the historicals.",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ "Please check the total time taken for each segment's creation and publish to deep storage, "
+ "as well as the total time taken for segment handoff to the historicals.",
+ "Check metrics to see if the creation, publish or handoff of any segment is taking longer than usual.",

Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com>
Co-authored-by: Benedict Jin <asdf2014@apache.org>
@AmatyaAvadhanula

Copy link
Copy Markdown
Contributor Author

@kfaraz, @asdf2014 Thank you for the review!

@AmatyaAvadhanula
AmatyaAvadhanula merged commit bd50506 into apache:master Aug 22, 2023
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
@kfaraz
kfaraz deleted the improve-completionTimeout-message branch October 27, 2023 08:32
riovic918data pushed a commit to riovic918data/druid that referenced this pull request Jun 12, 2026
…14636)

* Improve streaming ingestion completion timeout error message

Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com>
Co-authored-by: Benedict Jin <asdf2014@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants