Repository navigation
Remove deprecated DruidException, EntryExistsException - #14448
Conversation
|
This pull request has been marked as stale due to 60 days of inactivity. |
github-actions
Bot
added
Area - Streaming Ingestion
Area - Lookups
Area - Ingestion
labels
There was a problem hiding this comment.
LGTM, thanks for the cleanup! Since the deprecation of exception classes were noted in the 27.0.0 release notes, should we add a release note entry in this PR to mention that classes have now been removed, so it gets called out in the next release notes?
| private List<DataSegment> createBaseSegments() | ||
| { | ||
| return Arrays.asList( | ||
| createSegment("base", "2015-01-01T00Z/2015-01-02T00Z", "2015-01-02"), |
There was a problem hiding this comment.
Maybe save the base datasource name in a constant as it's used in quite a few places.
| @@ -257,10 +237,13 @@ public void testDuplicateInsertThrowsEntryExistsException() | |||
| Map<String, Object> status = ImmutableMap.of("count", 42); | |||
There was a problem hiding this comment.
This test name needs updating as the exception no longer exists: testDuplicateInsertThrowsEntryExistsException
|
Thanks for the review, @abhishekrb19 ! Thanks for reminding me about the release notes. I will update the PR description. |
Changes: - Remove deprecated `DruidException` (old one) and `EntryExistsException` - Use newly added comprehensive `DruidException` instead - Update error message in `SqlMetadataStorageActionHandler` when max packet limit is violated. - Factor out common code from several faults into `BaseFault`. - Slightly update javadoc in `DruidException` to render it correctly - Remove unused classes `SegmentToMove`, `SegmentToDrop` - Move `ServletResourceUtils` from module `druid-processing` to `druid-server` - Add utility method to build error Response from `DruidException`.
Changes:
DruidException(old one) andEntryExistsExceptionDruidExceptioninsteadSqlMetadataStorageActionHandlerwhen max packet limit is violated.BaseFault.DruidExceptionto render it correctlySegmentToMove,SegmentToDropServletResourceUtilsfrom moduledruid-processingtodruid-serverand add utility method to build error Response fromDruidException.Release Notes
The old
EntryExistsExceptionthrown when trying to insert a duplicate task in the metadata store has been removed. Instead, Druid now throws aDruidExceptionwith error codeentryAlreadyExists.This PR has: