Repository navigation
Update Guava to 19.0. - #13544
Closed
gianm wants to merge 2 commits into
Closed
Update Guava to 19.0.#13544gianm wants to merge 2 commits into
gianm wants to merge 2 commits into
Conversation
gianm
marked this pull request as draft
December 9, 2022 21:36
Contributor
Author
|
See #13532 for updates. Going a different direction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we use Guava 16.0.1. This is a very old version, but we continue to use it in order to maintain compatibility with Hadoop 2, which also bundles a very old version of Guava. As a community we have not yet made the decision to drop support for Hadoop 2 (https://lists.apache.org/thread/1j5w9dmt1gp8hx31tvrmyomcko4mlp03), but nevertheless, we'd like to update Calcite (#13532). Current versions of Calcite support a minimum of Guava 19.0, so this patch updates us to that version. We'll need to test it with Hadoop 2 to make sure nothing breaks.