Skip to content

Quieter streaming supervisors. - #13392

Merged
gianm merged 1 commit into
apache:masterfrom
gianm:supervisor-quieter
Nov 21, 2022
Merged

gianm merged 1 commit into
apache:masterfrom
gianm:supervisor-quieter

Conversation

@gianm

@gianm gianm commented Nov 21, 2022

Copy link
Copy Markdown
Contributor

Eliminates two common sources of noise with Kafka supervisors that have large numbers of tasks and partitions:

  1. Log the report at DEBUG rather than INFO level at each run cycle.
    It can get quite large, and can be retrieved via API when needed.

  2. Use log4j2.xml to quiet down the org.apache.kafka.clients.consumer.internals
    package. Avoids a log message per-partition per-minute as part of seeking
    to the latest offset in the reporting thread. In the tasks, where this
    sort of logging might be more useful, we have another log message with
    the same information: "Seeking partition[%s] to[%s]".

Eliminates two common sources of noise with Kafka supervisors that have
large numbers of tasks and partitions:

1) Log the report at DEBUG rather than INFO level at each run cycle.
   It can get quite large, and can be retrieved via API when needed.

2) Use log4j2.xml to quiet down the org.apache.kafka.clients.consumer.internals
   package. Avoids a log message per-partition per-minute as part of seeking
   to the latest offset in the reporting thread. In the tasks, where this
   sort of logging might be more useful, we have another log message with
   the same information: "Seeking partition[%s] to[%s]".
@kfaraz kfaraz added this to the 25.0 milestone Nov 21, 2022
@gianm

gianm commented Nov 21, 2022

Copy link
Copy Markdown
Contributor Author

Code coverage checks are failing because only one line changed, and it only gets logged at debug level. I suggest we merge the patch anyway, ignoring the coverage checks, once other tests are passing. I restarted the other failure, which I think was a flake.

@kfaraz

kfaraz commented Nov 21, 2022

Copy link
Copy Markdown
Contributor

Code coverage checks are failing because only one line changed, and it only gets logged at debug level. I suggest we merge the patch anyway, ignoring the coverage checks, once other tests are passing. I restarted the other failure, which I think was a flake.

Yeah, makes sense. I had triggered the phase 2 tests. I think some are still running. We can merge once they finish.

@gianm

gianm commented Nov 21, 2022

Copy link
Copy Markdown
Contributor Author

Yeah, makes sense. I had triggered the phase 2 tests. I think some are still running. We can merge once they finish.

Thanks. It looks like they're done now. I'll merge this.

@gianm
gianm merged commit c61313f into apache:master Nov 21, 2022
@gianm
gianm deleted the supervisor-quieter branch November 21, 2022 07:53
gianm added a commit to gianm/druid that referenced this pull request Jun 16, 2023
Follow-up to apache#13392, which added this to a single log4j2.xml.
abhishekagarwal87 pushed a commit that referenced this pull request Jun 19, 2023
Follow-up to #13392, which added this to a single log4j2.xml.
riovic918data pushed a commit to riovic918data/druid that referenced this pull request Jun 12, 2026
Eliminates two common sources of noise with Kafka supervisors that have
large numbers of tasks and partitions:

1) Log the report at DEBUG rather than INFO level at each run cycle.
   It can get quite large, and can be retrieved via API when needed.

2) Use log4j2.xml to quiet down the org.apache.kafka.clients.consumer.internals
   package. Avoids a log message per-partition per-minute as part of seeking
   to the latest offset in the reporting thread. In the tasks, where this
   sort of logging might be more useful, we have another log message with
   the same information: "Seeking partition[%s] to[%s]".
riovic918data pushed a commit to riovic918data/druid that referenced this pull request Jun 12, 2026
Follow-up to apache#13392, which added this to a single log4j2.xml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants