Repository navigation
Fixing the K8s task runner to work with MSQ - #13305
Conversation
|
@gianm you were right, the bug was due to the worker task's pod being scheduled but it wasn't yet launched (so it had no podIP yet) thus, the task location was partially set. The fix is pretty small, I tested this on my local cluster and MSQ now works. Let me know what you think. Thanks for helping look into this. |
|
@churromorales - does this PR has all the changes pushed? |
|
@abhishekagarwal87 it has even more, in our local fork i didn't write a test ;). Seriously though, here was the original issue: this fixes that issue, i tested and tasks index and i can query them, before it would not even start. |
| { | ||
| super(task.getId(), statusFuture, createdTime, createdTime); | ||
| this.task = task; | ||
| this.client = client; |
There was a problem hiding this comment.
where does it get accessed?
There was a problem hiding this comment.
Used for testing. I needed to inject the client to mock out
cryptoe
left a comment
cryptoe
left a comment
There was a problem hiding this comment.
@churromorales Thanks for the PR.
I went through it and it seems we are not setting TaskLocation.unknown() anywhere.
Maybe I am missing something.
@abhishekagarwal87 I am so sorry, you are absolutely right, I missed the core logic here that was causing the issue. I forgot to push up the last commit. Now it should be good. I am very sorry about that. |
I forgot to push up a commit that was local. I apologize. |
|
Thank you @churromorales |
* Fixing the K8s task runner to work with MSQ * Sorry incomplete PR Co-authored-by: Rahul Gidwani <r_gidwani@apple.com>
4 participants
MSQ can work with tasks that have not yet launched, there was a bug in the k8s task runner where you could return a null host because the pod was still not up. Fixed this to return a
TaskLocation.unknown()if this happens to msq works. Tested this on our internal clusters and it seemed to fix the problem with msq + k8s peon jobs.