Repository navigation
Provide service specific log4j overrides in containerized deployments - #13020
Merged
Merged
Conversation
capistrant
reviewed
Sep 8, 2022
capistrant
left a comment
capistrant
left a comment
Contributor
There was a problem hiding this comment.
one nit comment, but this seems like a useful idea in general
| # - DRUID_LOG4J -- set the entire log4j.xml verbatim | ||
| # - DRUID_LOG_LEVEL -- override the default log level in default log4j | ||
| # - DRUID_SERVICE_LOG4J -- set the entire service specific log4j.xml verbatim | ||
| # - DRUID_SERVICE_LOG_LEVEL -- override the default log level in the service specific log4j |
Contributor
There was a problem hiding this comment.
might want to note that this only works if the existing log level in the service log4j file is info
Contributor
Author
There was a problem hiding this comment.
Good point. Added the clarification.
FrankChen021
approved these changes
Sep 11, 2022
Member
|
@a2l007 oh, I forgot about the doc. It's better to document these new config in the |
Contributor
Author
|
@FrankChen021 Good catch, I've added the docs. |
This was referenced Dec 18, 2022
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
…apache#13020) * Provide service specific log4j overrides * Clarify comments * Add docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing druid script associated with the official Dockerfile provides support for altering log4j config present in the common config directory via env options. These options don't work for druid-operator based deployments since the operator pushes the log4j2 xml to the service specific directories by default.
This PR provides an option to override log4j configs setup at the service level directories so that it works with usecases similar to above.
This PR has: