Skip to content

Rework the druid docs and fix many mistakes - #1182

Merged
xvrl merged 1 commit into
masterfrom
better-docs
Mar 10, 2015
Merged

xvrl merged 1 commit into
masterfrom
better-docs

Conversation

@fjy

@fjy fjy commented Mar 9, 2015

Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably we should also mark this deprecated in code too, ZKPathsConfig

xvrl added a commit that referenced this pull request Mar 10, 2015
Rework the druid docs and fix many mistakes
@xvrl
xvrl merged commit 9f242ed into master Mar 10, 2015
@xvrl
xvrl deleted the better-docs branch March 10, 2015 21:23
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.05%) to 52.09% when pulling 891c191 on better-docs into e9b38f4 on master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.14%) to 52.21% when pulling 064d65a on better-docs into 0b46762 on master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.04%) to 52.11% when pulling 064d65a on better-docs into 0b46762 on master.

@xvrl xvrl modified the milestone: 0.7.1 Mar 13, 2015
@kfaraz kfaraz mentioned this pull request Jul 30, 2024
4 of 10 tasks
kfaraz added a commit that referenced this pull request Aug 6, 2024
Background:
ZK-based segment loading has been completely disabled in #15705 .
ZK `servedSegmentsPath` has been deprecated since Druid 0.7.1, #1182 .
This legacy path has been replaced by the `liveSegmentsPath` and is not used in the code anymore.

Changes:
- Never create ZK loadQueuePath as it is never used.
- Never create ZK servedSegmentsPath as it is never used.
- Do not create ZK liveSegmentsPath if announcement on ZK is disabled
- Fix up tests
riovic918data added a commit to riovic918data/druid that referenced this pull request Jun 12, 2026
Background:
ZK-based segment loading has been completely disabled in apache#15705 .
ZK `servedSegmentsPath` has been deprecated since Druid 0.7.1, apache#1182 .
This legacy path has been replaced by the `liveSegmentsPath` and is not used in the code anymore.

Changes:
- Never create ZK loadQueuePath as it is never used.
- Never create ZK servedSegmentsPath as it is never used.
- Do not create ZK liveSegmentsPath if announcement on ZK is disabled
- Fix up tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants