Repository navigation
Adding new metrics ingest/notices/queueSize and ingest/notices/time to give more visibility into supervisor notices queue size. - #11417
Merged
Conversation
harinirajendran
force-pushed
the
new_metric
branch
2 times, most recently
from
July 8, 2021 23:27
729bdf3 to
4712341
Compare
Contributor
Author
|
@jihoonson The same |
xvrl
reviewed
Jul 9, 2021
xvrl
reviewed
Jul 9, 2021
xvrl
reviewed
Jul 9, 2021
Member
|
would it make sense to emit a metric to also compute the time it takes to process each notice, this would also give us a sense of which notices take more time to process if we add a tag by notice type |
harinirajendran
force-pushed
the
new_metric
branch
from
July 10, 2021 05:32
4712341 to
0b2c352
Compare
Contributor
Author
Added one |
harinirajendran
force-pushed
the
new_metric
branch
5 times, most recently
from
July 11, 2021 16:09
c7054ed to
67d998c
Compare
xvrl
reviewed
Jul 13, 2021
xvrl
reviewed
Jul 13, 2021
harinirajendran
force-pushed
the
new_metric
branch
2 times, most recently
from
July 15, 2021 00:04
dffe30b to
ce5742e
Compare
xvrl
reviewed
Jul 20, 2021
xvrl
reviewed
Jul 20, 2021
harinirajendran
force-pushed
the
new_metric
branch
from
July 24, 2021 01:04
36b19ae to
4742687
Compare
xvrl
reviewed
Jul 29, 2021
…into supervisor notices queue size.
harinirajendran
force-pushed
the
new_metric
branch
from
July 30, 2021 01:13
4742687 to
26adf72
Compare
xvrl
approved these changes
Jul 30, 2021
harinirajendran
added a commit
to confluentinc/druid
that referenced
this pull request
Aug 6, 2021
…r notices queue size (apache#11417) (cherry picked from commit 995d99d)
harinirajendran
added a commit
to confluentinc/druid
that referenced
this pull request
Aug 6, 2021
…r notices queue size (apache#11417) (cherry picked from commit 995d99d)
harinirajendran
added a commit
to confluentinc/druid
that referenced
this pull request
Aug 12, 2021
…r notices queue size (apache#11417) (cherry picked from commit 995d99d)
xvrl
pushed a commit
to confluentinc/druid
that referenced
this pull request
Aug 12, 2021
…r notices queue size (apache#11417) (cherry picked from commit 995d99d)
harinirajendran
changed the title
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
…r notices queue size (apache#11417)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was trying to gather more info for #11414, I realized we do not have much visibility into the notices queue size inside Kafka stream supervisor. Hence adding a new metric to increase that visibility.
Testing done
I tested it locally with the logging emitter