Repository navigation
Allow ParseException for only InputRowParser and Parser in data ingestion #5639
Description
Currently, ParseException can be thrown in IncrementalIndex.toTimeAndDims() and Aggregator.aggregate() as well as InputRowParser and Parser. This results in callers should handle ParseException whenever calling them. Furthermore, #5418 introduces collecting metrics about errors while ingesting data, and ParseException from diverse places makes it difficult to make a unified metrics collector. This can be especially an issue when a new task type is introduced like in #5492 because we should add metrics collecting codes manually.
This issue can be addressed by allowing ParseException only in InputRowParser and Parser. To do so, we should be able to let them know what are the expected data types. Once InputRowParser returns a valid InputRow, then ParseException shouldn't be thrown because we've already done all parsing error checks.
Activity
stale commentedon Jun 21, 2019
This issue has been marked as stale due to 280 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.
stale commentedon Jul 5, 2019
This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.