Skip to content

KafkaIndexTask maxRowsInMemory is per-Sink, should be not-per-Sink #3271

Closed
Closed
KafkaIndexTask maxRowsInMemory is per-Sink, should be not-per-Sink#3271
Labels
Improvement
Milestone
0.9.2

Description

@gianm
gianm
opened on Jul 21, 2016

Since there is up to one Sink per time range per partition, you can actually potentially get a lot more rows in memory than you expect. Would be nice for it to apply across all Sinks.

Activity

  1. gianm
    added
    Improvement
    on Jul 21, 2016
  2. dclim
    added this to the milestone on Jul 22, 2016

  3. navis commented on Jul 26, 2016

    @navis
    navis
    on Jul 26, 2016
    Contributor

    seemed related to #2459, but that is for realtime task

  4. gianm commented on Jul 26, 2016

    @gianm
    gianm
    on Jul 26, 2016
    ContributorAuthor

    should be fixed by #3284 for appenderator/kafka.

    @navis thanks for pointing out #2459, will take a look.

  5. gianm
    modified the milestones: 0.9.2, on Jul 26, 2016

  6. fjy commented on Jul 26, 2016

    @fjy
    fjy
    on Jul 26, 2016
    Contributor

    👍 we should fix this

  7. dclim
    closed this as completedin #3284on Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Improvement

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions