[fix](dbt-doris): the commands dbt docs generate/serve fail due to wrong function signature#60779
Open
Lastv25 wants to merge 1 commit intoapache:masterfrom
Open
Conversation
Removed unused methods related to catalog retrieval and filtering schemas from the Doris adapter implementation. Use default dbt-adapter functions
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed methods related to catalog retrieval and filtering schemas from the Doris adapter implementation. Use default dbt-adapter functions.
What problem does this PR solve?
Problem Summary:
The
dbt docs ...commands do not work with the dbt-doris adapter due to the errorTypeError: DorisAdapter.get_catalog() takes 2 positional arguments but 3 were given. The signature of the get_catalog function changed in this commit dbt-labs/dbt-adapters@5d90ff9 . There is no need to redifine the get_catalog function in the adapter (same with _catalog_filter_table and _catalog_filter_schema functions), the default ones work.Solution:
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)