Skip to content

[fix](dbt-doris): the commands dbt docs generate/serve fail due to wrong function signature#60779

Open
Lastv25 wants to merge 1 commit intoapache:masterfrom
Lastv25:fix/dbt_doris_adapter_breacks_for_docs_generation
Open

[fix](dbt-doris): the commands dbt docs generate/serve fail due to wrong function signature#60779
Lastv25 wants to merge 1 commit intoapache:masterfrom
Lastv25:fix/dbt_doris_adapter_breacks_for_docs_generation

Conversation

@Lastv25
Copy link

@Lastv25 Lastv25 commented Feb 17, 2026

Removed methods related to catalog retrieval and filtering schemas from the Doris adapter implementation. Use default dbt-adapter functions.

What problem does this PR solve?

Problem Summary:

The dbt docs ... commands do not work with the dbt-doris adapter due to the error TypeError: DorisAdapter.get_catalog() takes 2 positional arguments but 3 were given . The signature of the get_catalog function changed in this commit dbt-labs/dbt-adapters@5d90ff9 . There is no need to redifine the get_catalog function in the adapter (same with _catalog_filter_table and _catalog_filter_schema functions), the default ones work.

Solution:

  • Remove functions get_catalog, _catalog_filter_schema and _catalog_filter_table from adatpter
  • Use default functions from the dbt-adapter module

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • [] Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Removed unused methods related to catalog retrieval and filtering schemas from the Doris adapter implementation. Use default dbt-adapter functions
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments