Skip to content

[chore](refactor) should not treat finished as ok#60766

Open
yiguolei wants to merge 2 commits intoapache:masterfrom
yiguolei:f1
Open

[chore](refactor) should not treat finished as ok#60766
yiguolei wants to merge 2 commits intoapache:masterfrom
yiguolei:f1

Conversation

@yiguolei
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Feb 14, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yiguolei
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 28968 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cd8a43845b4ad41d26f8011a98ce17b422ab0773, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17612	4490	4289	4289
q2	q3	10651	829	537	537
q4	4686	361	259	259
q5	7801	1238	1031	1031
q6	212	173	146	146
q7	796	846	681	681
q8	10516	1495	1356	1356
q9	6083	4764	4761	4761
q10	6876	1918	1637	1637
q11	451	258	236	236
q12	747	561	474	474
q13	17791	4250	3405	3405
q14	240	238	211	211
q15	917	800	799	799
q16	774	735	689	689
q17	761	878	421	421
q18	6051	5451	5245	5245
q19	1356	976	596	596
q20	527	675	493	493
q21	4495	1951	1441	1441
q22	403	318	261	261
Total cold run time: 99746 ms
Total hot run time: 28968 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4797	4549	4568	4549
q2	q3	1820	2304	1783	1783
q4	908	1201	767	767
q5	4040	4359	4467	4359
q6	199	178	145	145
q7	1755	1722	1565	1565
q8	2495	2757	2569	2569
q9	7262	7399	7497	7399
q10	2623	2805	2466	2466
q11	586	458	410	410
q12	493	613	518	518
q13	4149	4450	3593	3593
q14	291	308	270	270
q15	834	794	797	794
q16	698	764	751	751
q17	1204	1555	1317	1317
q18	7153	6932	6702	6702
q19	879	857	866	857
q20	2079	2148	2012	2012
q21	4002	3521	3275	3275
q22	487	472	393	393
Total cold run time: 48754 ms
Total hot run time: 46494 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 183784 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cd8a43845b4ad41d26f8011a98ce17b422ab0773, data reload: false

query5	4733	664	524	524
query6	348	232	227	227
query7	4233	487	275	275
query8	345	248	241	241
query9	8735	2778	2754	2754
query10	531	381	333	333
query11	16895	17370	17255	17255
query12	232	184	184	184
query13	2207	487	361	361
query14	6691	3373	3112	3112
query14_1	2999	2902	2910	2902
query15	213	199	180	180
query16	1031	509	467	467
query17	2002	754	697	697
query18	3147	483	358	358
query19	229	228	196	196
query20	163	136	129	129
query21	217	147	129	129
query22	5734	5621	4919	4919
query23	17273	16729	16599	16599
query23_1	16692	16655	16732	16655
query24	7291	1609	1221	1221
query24_1	1232	1220	1229	1220
query25	535	460	398	398
query26	1230	260	148	148
query27	2715	476	301	301
query28	4411	1857	1864	1857
query29	788	569	480	480
query30	311	248	206	206
query31	882	726	656	656
query32	82	70	77	70
query33	527	333	289	289
query34	911	907	569	569
query35	623	674	582	582
query36	1108	1133	1003	1003
query37	131	100	79	79
query38	2968	2913	2865	2865
query39	933	890	845	845
query39_1	823	831	835	831
query40	237	149	136	136
query41	62	62	57	57
query42	106	101	105	101
query43	377	390	352	352
query44	
query45	202	186	184	184
query46	863	979	619	619
query47	2101	2126	2104	2104
query48	307	311	221	221
query49	623	453	377	377
query50	678	285	217	217
query51	4105	4070	4068	4068
query52	102	105	102	102
query53	296	338	278	278
query54	297	269	258	258
query55	86	83	86	83
query56	305	310	321	310
query57	1367	1334	1267	1267
query58	287	275	266	266
query59	2585	2697	2509	2509
query60	340	338	323	323
query61	146	149	146	146
query62	623	600	536	536
query63	303	273	275	273
query64	4854	1277	983	983
query65	
query66	1413	465	359	359
query67	16400	16302	16316	16302
query68	
query69	392	320	295	295
query70	987	957	935	935
query71	330	312	296	296
query72	2792	2659	2384	2384
query73	534	543	319	319
query74	9972	9911	9767	9767
query75	2846	2726	2462	2462
query76	2290	1036	653	653
query77	359	367	297	297
query78	11240	11356	10690	10690
query79	2973	795	588	588
query80	1785	648	513	513
query81	602	286	246	246
query82	996	147	119	119
query83	334	258	237	237
query84	260	121	101	101
query85	880	489	430	430
query86	489	303	307	303
query87	3120	3145	2996	2996
query88	3575	2683	2667	2667
query89	415	358	337	337
query90	2147	174	169	169
query91	166	159	137	137
query92	82	76	74	74
query93	1777	824	505	505
query94	647	330	289	289
query95	586	335	314	314
query96	649	519	227	227
query97	2440	2513	2388	2388
query98	237	216	215	215
query99	972	988	908	908
Total cold run time: 259524 ms
Total hot run time: 183784 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 18.75% (6/32) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.69% (19539/37084)
Line Coverage 36.26% (182258/502577)
Region Coverage 32.59% (141329/433628)
Branch Coverage 33.62% (61248/182176)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 53.12% (17/32) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.34% (20836/36337)
Line Coverage 40.37% (202364/501328)
Region Coverage 37.00% (162073/438005)
Branch Coverage 37.72% (68979/182880)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments