Skip to content

refactor: hudson.maven.MavenModuleSet is now treated as a scope#7599

Merged
klesh merged 4 commits into
apache:mainfrom
sstojak1:feat-mavenmoduleset-as-scope
Jun 18, 2024
Merged

refactor: hudson.maven.MavenModuleSet is now treated as a scope#7599
klesh merged 4 commits into
apache:mainfrom
sstojak1:feat-mavenmoduleset-as-scope

Conversation

@sstojak1

@sstojak1 sstojak1 commented Jun 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?
hudson.maven.MavenModuleSet Jenkins pipeline will now be treated as a scope

Does this close any open issues?

Closes 7598

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. component/plugins This issue or PR relates to plugins pr-type/feature-development This PR is to develop a new feature labels Jun 10, 2024
@d4x1

d4x1 commented Jun 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

@sstojak1 Have you tested it ? And it works as expected?
Please help to fix the CI errors(https://devlake.apache.org/community/MakingContributions/development-workflow#commit-tool This doc will help). Thanks.

@klesh

klesh commented Jun 14, 2024

Copy link
Copy Markdown
Contributor

Looks good to me in terms of a fix.
I wonder if it would make more sense to make scope the default? That is, to only match for groups and let the others be scope by default?

@klesh

klesh commented Jun 14, 2024

Copy link
Copy Markdown
Contributor

@sstojak1 BTW, are you interested in joining Apache as a Committer? I would like to invite you if you are up for it. Please reach me out on Slack if you do, my name is "Klesh Wong" on the channel.

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 14, 2024
@sstojak1 sstojak1 changed the title hudson.maven.MavenModuleSet is now treated as a scope refactor: hudson.maven.MavenModuleSet is now treated as a scope Jun 14, 2024
@sstojak1

sstojak1 commented Jun 14, 2024

Copy link
Copy Markdown
Contributor Author

@klesh makes sense to have scope as a default since there should be more jobs that should be treated as scope then group.
I've tweaked the logic a bit by blending the new and old approaches. Please review.
WorkflowMultiBranchProject is unique—it has jobs but should be considered as 'scope', hence the extra check in isGroup.

@klesh

klesh commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

@gustavobini Would you like to take a look at the code? Thanks in advance.

@gustavobini

gustavobini commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

@gustavobini Would you like to take a look at the code? Thanks in advance.

We had talked over Slack about this. It's a good solution. Thanks @sstojak1

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 18, 2024
@klesh klesh merged commit d9318cf into apache:main Jun 18, 2024
@klesh

klesh commented Jun 18, 2024

Copy link
Copy Markdown
Contributor

Thank you all.

@sstojak1 sstojak1 deleted the feat-mavenmoduleset-as-scope branch June 18, 2024 11:27
klesh pushed a commit that referenced this pull request Jul 16, 2024
@sstojak1
refactor: hudson.maven.MavenModuleSet is now treated as a scope (#7599)
2655e8b 
* hudson.maven.MavenModuleSet is now treated as a scope

* refactor: scope is now the default

---------

Co-authored-by: Josip Stojak <Josip.Stojak@infobip.com>
abeizn pushed a commit that referenced this pull request Jul 16, 2024
@sstojak1
refactor: hudson.maven.MavenModuleSet is now treated as a scope (#7599)…
2be4ceb 
… (#7745)

* hudson.maven.MavenModuleSet is now treated as a scope

* refactor: scope is now the default

---------

Co-authored-by: sstojak1 <18380216+sstojak1@users.noreply.github.com>
Co-authored-by: Josip Stojak <Josip.Stojak@infobip.com>
@klesh klesh mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@klesh klesh klesh approved these changes

Assignees

No one assigned

Labels

component/plugins This issue or PR relates to plugins lgtm This PR has been approved by a maintainer pr-type/feature-development This PR is to develop a new feature size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug][Jenkins] MavenModuleSet should be treated as a scope

4 participants

@sstojak1 @d4x1 @klesh @gustavobini