Skip to content

refactor: clarify shared traits with associated entries#166

Merged
tisonkun merged 1 commit into
apache:mainfrom
ariesdevil:dev_ariesdevil
Jul 26, 2026
Merged

refactor: clarify shared traits with associated entries#166
tisonkun merged 1 commit into
apache:mainfrom
ariesdevil:dev_ariesdevil

Conversation

@ariesdevil

Copy link
Copy Markdown
Contributor

Summary

  • Replace ambiguous Raw* names in shared Theta/Tuple internals with semantic names.
  • Make Entry an associated type of ThetaFamilySketchView.
  • Simplify Union, Intersection, and A-not-B type constraints.
  • Rename internal wrapper fields to state or operator.

Testing

  • cargo test -p datasketches --features theta,tuple
  • RUSTDOCFLAGS="-D warnings" cargo doc -p datasketches --no-deps --features theta,tuple

@tisonkun tisonkun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. 3 comments here:

  1. The following signature looks weird (not symmetrical). At least I need one more consideration.
        A: ThetaFamilySketchView,
        B: ThetaFamilySketchView<Entry = A::Entry>,
  1. operator fields can be op?
  2. I wonder if AnotB should be ANotB to follow camel case. See #155 (comment).

@ariesdevil

Copy link
Copy Markdown
Contributor Author

Fixed, PTAL again.

@tisonkun
tisonkun merged commit c17f9c0 into apache:main Jul 26, 2026
10 checks passed
@tisonkun

Copy link
Copy Markdown
Member

Thanks for your contribution @ariesdevil!

@ariesdevil
ariesdevil deleted the dev_ariesdevil branch July 26, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants