refactor: clarify shared traits with associated entries#166
Merged
Conversation
tisonkun
reviewed
Jul 26, 2026
tisonkun
left a comment
Member
There was a problem hiding this comment.
Generally LGTM. 3 comments here:
- The following signature looks weird (not symmetrical). At least I need one more consideration.
A: ThetaFamilySketchView,
B: ThetaFamilySketchView<Entry = A::Entry>,operatorfields can beop?- I wonder if
AnotBshould beANotBto follow camel case. See #155 (comment).
ariesdevil
force-pushed
the
dev_ariesdevil
branch
from
July 26, 2026 12:42
d7e2b6c to
bcb1cce
Compare
Contributor
Author
|
Fixed, PTAL again. |
tisonkun
approved these changes
Jul 26, 2026
Member
|
Thanks for your contribution @ariesdevil! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raw*names in shared Theta/Tuple internals with semantic names.Entryan associated type ofThetaFamilySketchView.stateoroperator.Testing
cargo test -p datasketches --features theta,tupleRUSTDOCFLAGS="-D warnings" cargo doc -p datasketches --no-deps --features theta,tuple